build/android/resource_sizes.py - Issue 2804623003: [Android] Fix resource_sizes for APKs that have no native library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/resource_sizes.py

Issue 2804623003: [Android] Fix resource_sizes for APKs that have no native library. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/resource_sizes.py

diff --git a/build/android/resource_sizes.py b/build/android/resource_sizes.py

index 89e7dca11a3453f01c61ba09e0c95601511f8534..77000b9ded635f4d25125bd85079ebd0c9abe028 100755

--- a/build/android/resource_sizes.py

+++ b/build/android/resource_sizes.py

@@ -299,6 +299,8 @@ class _FileGroup(object):

None)

def FindLargest(self):

+ if not self._zip_infos:

+ return None

return max(self._zip_infos, key=lambda i: i.file_size)

def ComputeZippedSize(self):

« no previous file with comments | « no previous file | no next file » | no next file with comments »