Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: pkg/compiler/lib/src/io/position_information.dart

Issue 2804613003: Make lines and columns one-based in SourceLocation. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/io/source_information.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/io/position_information.dart
diff --git a/pkg/compiler/lib/src/io/position_information.dart b/pkg/compiler/lib/src/io/position_information.dart
index 0400e61535cb427281ccdc37dd81b9043bc5d15f..d6889d71dc0492dc32bee91d7014af1f73d621c5 100644
--- a/pkg/compiler/lib/src/io/position_information.dart
+++ b/pkg/compiler/lib/src/io/position_information.dart
@@ -69,12 +69,12 @@ class PositionSourceInformation extends SourceInformation {
sb.write('$uriText:');
// Use 1-based line/column info to match usual dart tool output.
if (startPosition != null) {
- sb.write('[${startPosition.line + 1},'
- '${startPosition.column + 1}]');
+ sb.write('[${startPosition.line},'
+ '${startPosition.column}]');
}
if (closingPosition != null) {
- sb.write('-[${closingPosition.line + 1},'
- '${closingPosition.column + 1}]');
+ sb.write('-[${closingPosition.line},'
+ '${closingPosition.column}]');
}
return sb.toString();
}
« no previous file with comments | « no previous file | pkg/compiler/lib/src/io/source_information.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698