Network traffic annotation added to cloud_print_url_fetcher.

chrome/service/cloud_print/cloud_print_url_fetcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/service/cloud_print/cloud_print_url_fetcher.h"
 
 #include <stddef.h>
 
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
 #include "chrome/common/cloud_print/cloud_print_constants.h"
 #include "chrome/common/cloud_print/cloud_print_helpers.h"
 #include "chrome/service/cloud_print/cloud_print_service_helpers.h"
 #include "chrome/service/cloud_print/cloud_print_token_store.h"
 #include "chrome/service/net/service_url_request_context_getter.h"
 #include "chrome/service/service_process.h"
 #include "components/data_use_measurement/core/data_use_user_data.h"
 #include "net/base/load_flags.h"
 #include "net/http/http_status_code.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_status.h"
 #include "url/gurl.h"
 
 namespace cloud_print {
 
 namespace {
 
 void ReportRequestTime(CloudPrintURLFetcher::RequestType type,
                        base::TimeDelta time) {
@@ skipping 221 matching lines @@
     int max_retries,
     const std::string& post_data_mime_type,
     const std::string& post_data,
     const std::string& additional_headers) {
   DCHECK(delegate);
   type_ = type;
   UMA_HISTOGRAM_ENUMERATION("CloudPrint.UrlFetcherRequestType", type,
                             REQUEST_MAX);
   // Persist the additional headers in case we need to retry the request.
   additional_headers_ = additional_headers;
-  request_ = net::URLFetcher::Create(0, url, request_type, this);
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("cloud_print_url_fetcher", R"(
+        semantics {
+          sender: "Cloud Print"
+          description:
+            "Google Cloud Print allows users to print to printers from Chrome "
+            "and Android without needing to install print drivers."
+          trigger:
+            "Printing and running background Cloud Print services."

[Ramin Halavati, 2017/04/19 05:59:07]

Can "background" be elaborated?

[Lei Zhang, 2017/04/19 19:27:25]

This is part of the Cloud Print Connector that can run as a separate service
process. Which is why we are in chrome/service here. The Connector can be
standalone in the sense that it is separate from the entire
browser/renderer/gpu/utility process hierarchy.

+          data: "..."

[Ramin Halavati, 2017/04/19 05:59:07]

What is sent?

[Lei Zhang, 2017/04/19 19:27:26]

StartPostRequest() and StartGetRequest() both use this helper function. Tracing
their callers, there are a total of 12 non-test callers. So as is, lots of
different things.

BTW, I didn't write any of this code, so I'm just looking this up as we go. You
could do the same, but I'm not sure that's what you want to do. Just to set
expectations, shall we continue this Q&A format?

+          destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER/LOCAL

[Ramin Halavati, 2017/04/19 05:59:07]

I assume it should be OTHER?

[Lei Zhang, 2017/04/19 19:27:25]

That would be consistent with "cloud_print_privet_register" and friends.

+        }
+        policy {
+          cookies_allowed: false
+          setting:
+            "This feature cannot be disabled by settings."
+          chrome_policy {
+            CloudPrintProxyEnabled {
+              policy_options {mode: MANDATORY}
+              CloudPrintProxyEnabled: false
+            }
+          }
+          chrome_policy {
+            CloudPrintSubmitEnabled {
+              policy_options {mode: MANDATORY}
+              CloudPrintSubmitEnabled: false
+            }
+          }
+        })");

[Ramin Halavati, 2017/04/19 05:59:07]

Are both policies required to disable this request or either of them does that?

[Lei Zhang, 2017/04/19 19:27:25]

CloudPrintSubmitEnabled doesn't belong here. It's used in the browser process,
not the service process.

+  request_ =
+      net::URLFetcher::Create(0, url, request_type, this, traffic_annotation);
   data_use_measurement::DataUseUserData::AttachToFetcher(
       request_.get(), data_use_measurement::DataUseUserData::CLOUD_PRINT);
   request_->SetRequestContext(GetRequestContextGetter());
   // Since we implement our own retry logic, disable the retry in URLFetcher.
   request_->SetAutomaticallyRetryOn5xx(false);
   request_->SetMaxRetriesOn5xx(max_retries);
   delegate_ = delegate;
   SetupRequestHeaders();
   request_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
                          net::LOAD_DO_NOT_SAVE_COOKIES);
@@ skipping 23 matching lines @@
   ServiceURLRequestContextGetter* getter =
       g_service_process->GetServiceURLRequestContextGetter();
   // Now set up the user agent for cloudprint.
   std::string user_agent = getter->user_agent();
   base::StringAppendF(&user_agent, " %s", kCloudPrintUserAgent);
   getter->set_user_agent(user_agent);
   return getter;
 }
 
 }  // namespace cloud_print