Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Unified Diff: tools/testing/dart/browser_controller.dart

Issue 2804543004: Bug fix in browser testing: add null check. (Closed)
Patch Set: Remove error from test scripts' browser driver window script. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/browser_controller.dart
diff --git a/tools/testing/dart/browser_controller.dart b/tools/testing/dart/browser_controller.dart
index 95334e7accddee53296e9a7848dbf2eaf513b7ca..ef2f189c45aeae4c8bb195977de8507607379308 100644
--- a/tools/testing/dart/browser_controller.dart
+++ b/tools/testing/dart/browser_controller.dart
@@ -1805,11 +1805,17 @@ body div {
function sendStatusUpdate () {
var dom =
embedded_iframe.contentWindow.document.documentElement.innerHTML;
- reportMessage('Status:\\n Messages received multiple times:\\n ' +
- html_test.double_received_messages +
- '\\n Unexpected messages:\\n ' +
- html_test.unexpected_messages +
- '\\n DOM:\\n ' + dom, false, true);
+ var message = 'Status:\\n';
+ if (html_test != null) {
+ message +=
+ ' Messages received multiple times:\\n' +
+ ' ' + html_test.double_received_messages + '\\n' +
+ ' Unexpected messages:\\n' +
+ ' ' + html_test.unexpected_messages + '\\n';
+ }
+ message += ' DOM:\\n' +
+ ' ' + dom;
+ reportMessage(message, false, true);
}
function sendRepeatingStatusUpdate() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698