Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2804543004: Bug fix in browser testing: add null check. (Closed)

Created:
3 years, 8 months ago by Bill Hesse
Modified:
3 years, 8 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix an error where html_test (which is usually null) is used without checking for null, when reporting status back to the test controller. BUG= R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/ac23816bb721ffc40b2e0f1af7400b65233a7f8a

Patch Set 1 : Remove error from test scripts' browser driver window script. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M tools/testing/dart/browser_controller.dart View 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Bill Hesse
3 years, 8 months ago (2017-04-06 14:36:30 UTC) #3
ahe
lgtm
3 years, 8 months ago (2017-04-06 14:56:00 UTC) #5
Bill Hesse
3 years, 8 months ago (2017-04-06 15:16:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
ac23816bb721ffc40b2e0f1af7400b65233a7f8a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698