Chromium Code Reviews Chromium Code Reviews
Issue 2804533002:
Update Error Event inside a worker to provide the exact exception value (Closed)
| Index: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/service-worker-error-event.https.html |
| diff --git a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/service-worker-error-event.https.html b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/service-worker-error-event.https.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..006cb78f38fe0e3843e98ab882a4ac771f59dc2c |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/service-worker-error-event.https.html |
| @@ -0,0 +1,30 @@ |
| +<!DOCTYPE html> |
| +<title>ServiceWorkerGlobalScope: Error event error message</title> |
| +<script src='/resources/testharness.js'></script> |
| +<script src='/resources/testharnessreport.js'></script> |
| +<script src='../resources/test-helpers.sub.js'></script> |
| +<script> |
| +promise_test(function(t) { |
| + var script = 'resources/error-worker.js'; |
| + var scope = 'resources/scope/service-worker-error-event'; |
| + var errorname = 'testError' |
| + return service_worker_unregister_and_register(t, script, scope) |
| + .then(registration => { |
| + var serviceworker; |
| + serviceworker = registration.installing; |
| + return new Promise(function(resolve) { |
| + navigator.serviceWorker.onmessage = resolve; |
| + serviceworker.postMessage(''); |
|
nhiroki
2017/04/06 06:56:50
optional: you could squash line 13-14 into this li
yiyix
2017/04/06 07:27:51
Done.
|
| + }); |
| + }) |
| + .then(function(e) { |
|
nhiroki
2017/04/06 06:56:50
arrow function?
yiyix
2017/04/06 07:27:51
Done.
|
| + assert_equals(e.data.value, errorname, 'error type'); |
| + assert_greater_than( |
| + e.data.message.indexOf(errorname), -1, 'error message'); |
| + assert_greater_than( |
| + e.data.filename.indexOf('error-worker.js'), -1, 'filename'); |
|
nhiroki
2017/04/06 06:56:50
How about replacing 'error-worker.js' with |script
yiyix
2017/04/06 07:27:51
Done.
|
| + assert_equals(e.data.lineno, 5, 'error line number'); |
| + assert_equals(e.data.colno, 3, 'error column number'); |
| + }); |
| + }, 'Error handlers inside serviceworker should see the error value'); |
|
nhiroki
2017/04/06 06:56:50
...should see the attributes of ErrorEvent?
|
| +</script> |
