Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1374)

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/service-worker-error-event.https.html

Issue 2804533002: Update Error Event inside a worker to provide the exact exception value (Closed)
Patch Set: address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/service-worker-error-event.https.html
diff --git a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/service-worker-error-event.https.html b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/service-worker-error-event.https.html
new file mode 100644
index 0000000000000000000000000000000000000000..925cddc463d74b2073af48c415fd562bbf1bb47b
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/service-worker-error-event.https.html
@@ -0,0 +1,27 @@
+<!DOCTYPE html>
+<title>ServiceWorkerGlobalScope: Error event error message</title>
+<script src='/resources/testharness.js'></script>
+<script src='/resources/testharnessreport.js'></script>
+<script src='../resources/test-helpers.sub.js'></script>
+<script>
+promise_test(function(t) {
+ var script = 'resources/error-worker.js';
+ var scope = 'resources/scope/service-worker-error-event';
+ var errorname = 'testError'
+ var serviceworker;
nhiroki 2017/04/06 04:56:44 You can move this variable declaration to line 14.
yiyix 2017/04/06 06:33:55 Done. true, i don't need serviceworker in the seco
+ return service_worker_unregister_and_register(t, script, scope)
+ .then(registration => {
+ serviceworker = registration.installing;
+ return new Promise(function(resolve) {
+ navigator.serviceWorker.onmessage = resolve;
+ serviceworker.postMessage('');
+ });
+ })
+ .then(function(e) {
+ assert_equals(e.data.value, errorname, 'error type');
+ assert_greater_than(e.data.message.indexOf(errorname), -1, 'error message');
shimazu 2017/04/06 04:52:30 ditto
yiyix 2017/04/06 06:33:55 Done.
+ assert_equals(e.data.lineno, 5, 'error line number');
+ assert_equals(e.data.colno, 3, 'error column number');
+ });
+ }, 'Error handlers inside serviceworker should see the error value');
+</script>

Powered by Google App Engine
This is Rietveld 408576698