third_party/WebKit/LayoutTests/fast/workers/dedicated-worker-error-event.html - Issue 2804533002: Update Error Event inside a worker to provide the exact exception value

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/workers/dedicated-worker-error-event.html

Issue 2804533002: Update Error Event inside a worker to provide the exact exception value (Closed)

Patch Set: fix nits Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/workers/resources/error-script.js » ('j') | third_party/WebKit/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/error-worker-script.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <meta charset=utf-8>

	3 <title>Dedicated Worker: Error event error message</title>

	4 <script src=../../resources/testharness.js></script>

	5 <script src=../../resources/testharnessreport.js></script>

	6 <script>

	7 promise_test(function(t) {
	nhiroki 2017/04/06 01:50:35 Can you add a comment like this? // TODO(yiyix): Can you add a comment like this? // TODO(yiyix): This test will be superseded by external/wpt/workers/Worker_ErrorEvent_error.htm once https://crbug.com/708857 is fixed. yiyix 2017/04/06 04:38:19 Done. Show quoted text On 2017/04/06 01:50:35, nhiroki wrote: > Can you add a comment like this? > > // TODO(yiyix): This test will be superseded by > external/wpt/workers/Worker_ErrorEvent_error.htm once https://crbug.com/708857 > is fixed. Done.
	8 return new Promise(function(resolve) {
	nhiroki 2017/04/06 01:50:35 Optional: Arrow function would be simpler: return Optional: Arrow function would be simpler: return new Promise(resolve => { // do something }) see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/A... yiyix 2017/04/06 04:38:19 Done. Show quoted text On 2017/04/06 01:50:35, nhiroki wrote: > Optional: Arrow function would be simpler: > > return new Promise(resolve => { > // do something > }) > > see > https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/A... Done.
	9 var worker = new Worker('resources/error-script.js');

	10 worker.onmessage = resolve;

	11 })
	nhiroki 2017/04/06 01:50:35 +2 indents for line 8-11 return new Promise(r +2 indents for line 8-11 return new Promise(resolve => { var worker = new Worker('resources/error-script.js); worker.onmessage = resolve; }) .then(e => assert_equals(e.data.value, 'testError')); yiyix 2017/04/06 04:38:19 Done. Show quoted text On 2017/04/06 01:50:35, nhiroki wrote: > +2 indents for line 8-11 > > return new Promise(resolve => { > var worker = new Worker('resources/error-script.js); > worker.onmessage = resolve; > }) > .then(e => assert_equals(e.data.value, 'testError')); Done.
	12 .then(function(e) {

	13 assert_equals(e.data.value, 'testError');

	14 });

	15 }, 'Error handlers inside a worker should see the error value');

	16 </script>

OLD	NEW