third_party/WebKit/LayoutTests/fast/workers/dedicated-worker-error-event.html - Issue 2804533002: Update Error Event inside a worker to provide the exact exception value

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/workers/dedicated-worker-error-event.html

Issue 2804533002: Update Error Event inside a worker to provide the exact exception value (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/workers/resources/error-script.js » ('j') | third_party/WebKit/LayoutTests/fast/workers/resources/error-script.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <meta charset=utf-8>

	3 <title>Dedicated Worker: Error event error message</title>

	4 <script src=../../resources/testharness.js></script>

	5 <script src=../../resources/testharnessreport.js></script>

	6 <script>

	7 var t = async_test('Error handlers inside a worker should see the error value');

	8

	9 test(function() {
	shimazu 2017/04/05 07:23:22 Could you use promise_test to write async test lik Could you use promise_test to write async test like the following instead of async_test? -- promise_test(() => { return new Promise(resolve => { var worker = new Worker(...); worker.onmessage = resolve; }) .then(e => { assert_true(...); ... }); }); yiyix 2017/04/05 09:02:55 Done. Show quoted text On 2017/04/05 07:23:22, shimazu wrote: > Could you use promise_test to write async test like the following instead of > async_test? > > -- > promise_test(() => { > return new Promise(resolve => { > var worker = new Worker(...); > worker.onmessage = resolve; > }) > .then(e => { > assert_true(...); > ... > }); > }); Done.
	10 var worker = new Worker('resources/error-script.js');

	11 worker.onmessage = t.step_func(function(e) {

	12 var data = e.data;
	shimazu 2017/04/05 07:23:22 You can use e.data directly for checking the param You can use e.data directly for checking the parameter. yiyix 2017/04/05 09:02:55 Done. Show quoted text On 2017/04/05 07:23:22, shimazu wrote: > You can use e.data directly for checking the parameter. Done.
	13 assert_true(data.source == 'event listener');
	shimazu 2017/04/05 07:23:22 asser_equals is preferable for comparison. asser_equals is preferable for comparison. yiyix 2017/04/05 09:02:55 Done. Show quoted text On 2017/04/05 07:23:22, shimazu wrote: > asser_equals is preferable for comparison. Done.
	14 assert_equals(data.value, 'testError');

	15 t.done();

	16 });

	17 });

	18 </script>

OLD	NEW