Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(14)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/fast/workers/resources/error-script.js
Issue
2804533002
:
Update Error Event inside a worker to provide the exact exception value (Closed)
Patch Set: address comments
Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/error-worker.js
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/service-worker-error-event.https.html
third_party/WebKit/LayoutTests/fast/workers/dedicated-worker-error-event.html
third_party/WebKit/LayoutTests/fast/workers/resources/error-script.js
third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
third_party/WebKit/Source/core/events/ErrorEvent.h
third_party/WebKit/Source/core/events/ErrorEvent.cpp
View unified diff
|
Download patch
« third_party/WebKit/LayoutTests/fast/workers/dedicated-worker-error-event.html
('K') |
« third_party/WebKit/LayoutTests/fast/workers/dedicated-worker-error-event.html
('k') |
third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
addEventListener("error", function(e) {
2
postMessage({ source: "event listener", value: e.error });
nhiroki
2017/04/06 04:56:45
"source:" is no longer necessary.
"source:" is no longer necessary.
yiyix
2017/04/06 06:33:56
Done.
Show quoted text
On 2017/04/06 04:56:45, nhiroki wrote: > "source:" is no longer necessary.
Done.
3
});
4
5
throw "testError";
OLD
NEW
« third_party/WebKit/LayoutTests/fast/workers/dedicated-worker-error-event.html
('K') |
« third_party/WebKit/LayoutTests/fast/workers/dedicated-worker-error-event.html
('k') |
third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp »
('j') |
no next file with comments »
Issue 2804533002: Update Error Event inside a worker to provide the exact exception value (Closed)
Created 3 years, 8 months ago by yiyix
Modified 3 years, 8 months ago
Reviewers: shimazu, nhiroki, falken, haraken
Base URL:
Comments: 80
This is Rietveld
408576698
Chromium Code Reviews
Issue 2804533002:
Update Error Event inside a worker to provide the exact exception value (Closed)
