third_party/WebKit/LayoutTests/fast/workers/dedicated-worker-error-event.html - Issue 2804533002: Update Error Event inside a worker to provide the exact exception value

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/workers/dedicated-worker-error-event.html

Issue 2804533002: Update Error Event inside a worker to provide the exact exception value (Closed)

Patch Set: address comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <meta charset=utf-8>

	3 <title>Dedicated Worker: Error event error message</title>

	4 <script src=../../resources/testharness.js></script>

	5 <script src=../../resources/testharnessreport.js></script>

	6 <script>

	7 // TODO(yiyix): This test will be superseded by

	8 // external/wpt/workers/Worker_ErrorEvent_error.htm once

	9 // https://crbug.com/708857 is fixed.

	10 promise_test(function(t) {

	11 return new Promise(resolve => {

	12 var worker = new Worker('resources/error-script.js');

	13 worker.onmessage = resolve;

	14 })

	15 .then( e => assert_equals(e.data.value, 'testError'));
	nhiroki 2017/04/06 04:56:44 nit: Can you remove an extra space before 'e'? nit: Can you remove an extra space before 'e'? yiyix 2017/04/06 06:33:56 Done. Show quoted text On 2017/04/06 04:56:44, nhiroki wrote: > nit: Can you remove an extra space before 'e'? Done.
	16 }, 'Error handlers inside a worker should see the error value');

	17 </script>

OLD	NEW