Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 2804503002: MD Bookmarks: Allow 'complex' actions to access the page state directly (Closed)

Created:
3 years, 8 months ago by tsergeant
Modified:
3 years, 8 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, arv+watch_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Allow 'complex' actions to access the page state directly This adds a new file, complex_actions.js, which contains action creators that perform complex logic based off the page state. Splitting the actions in this way improves testability and works well with Closure. BUG=697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Self-review #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -111 lines) Patch
M chrome/browser/browser_resources.grd View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/actions.html View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/actions.js View 1 4 chunks +19 lines, -42 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/api_listener.js View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/compiled_resources2.gyp View 1 5 chunks +15 lines, -3 lines 0 comments Download
A chrome/browser/resources/md_bookmarks/complex_actions.js View 1 1 chunk +68 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/item.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/test/data/webui/md_bookmarks/complex_actions_test.js View 1 1 chunk +77 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/list_test.js View 1 chunk +7 lines, -37 lines 1 comment Download
M chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/reducers_test.js View 1 11 chunks +30 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
tsergeant
PTAL https://codereview.chromium.org/2804503002/diff/20001/chrome/test/data/webui/md_bookmarks/list_test.js File chrome/test/data/webui/md_bookmarks/list_test.js (left): https://codereview.chromium.org/2804503002/diff/20001/chrome/test/data/webui/md_bookmarks/list_test.js#oldcode35 chrome/test/data/webui/md_bookmarks/list_test.js:35: test('selects individual items', function() { I've removed some ...
3 years, 8 months ago (2017-04-06 03:36:04 UTC) #3
tsergeant
3 years, 8 months ago (2017-04-10 02:59:26 UTC) #8
FWIW, I'm putting this CL on ice while I decide whether we actually need it.

Powered by Google App Engine
This is Rietveld 408576698