Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: third_party/WebKit/Source/core/fileapi/File.h

Issue 2804403003: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/fileapi (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fileapi/File.h
diff --git a/third_party/WebKit/Source/core/fileapi/File.h b/third_party/WebKit/Source/core/fileapi/File.h
index c70d7f3a5dd3dff79b6657f5311e4ab852cf54f9..0bfe2951205006f58cec8525d90895582e7c804a 100644
--- a/third_party/WebKit/Source/core/fileapi/File.h
+++ b/third_party/WebKit/Source/core/fileapi/File.h
@@ -123,7 +123,9 @@ class CORE_EXPORT File final : public Blob {
}
KURL FileSystemURL() const {
- ASSERT(HasValidFileSystemURL());
+#if DCHECK_IS_ON()
+ DCHECK(HasValidFileSystemURL());
+#endif
return file_system_url_;
}
@@ -161,7 +163,9 @@ class CORE_EXPORT File final : public Blob {
void AppendTo(BlobData&) const override;
const String& GetPath() const {
- ASSERT(HasValidFilePath());
+#if DCHECK_IS_ON()
+ DCHECK(HasValidFilePath());
+#endif
alancutter (OOO until 2018) 2017/04/10 00:23:41 Why are these guards necessary?
Hwanseung Lee 2017/04/10 15:01:31 HasValidFilePath() is inside of "#if DCHECK_IS_ON(
return path_;
}
const String& name() const { return name_; }

Powered by Google App Engine
This is Rietveld 408576698