Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: services/service_manager/public/cpp/service.h

Issue 2804373002: Eliminate Connector::Connect(), Connection, etc. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/public/cpp/service.h
diff --git a/services/service_manager/public/cpp/service.h b/services/service_manager/public/cpp/service.h
index db5ad501705a4e398a7924d73886fb5b608b5aac..9d0c04e856aec83733218722c2bb3fb3b98a7024 100644
--- a/services/service_manager/public/cpp/service.h
+++ b/services/service_manager/public/cpp/service.h
@@ -12,7 +12,6 @@
namespace service_manager {
-class InterfaceRegistry;
class ServiceContext;
struct ServiceInfo;
@@ -28,16 +27,6 @@ class Service {
// will be made before this.
virtual void OnStart();
- // Called each time a connection to this service is brokered by the Service
- // Manager. Implement this to expose interfaces to other services.
- //
- // Return true if the connection should succeed or false if the connection
- // should be rejected.
- //
- // The default implementation returns false.
- virtual bool OnConnect(const ServiceInfo& remote_info,
- InterfaceRegistry* registry);
-
// Called when the service identified by |source_info| requests this service
// bind a request for |interface_name|. If this method has been called, the
// service manager has already determined that policy permits this interface
@@ -89,8 +78,6 @@ class ForwardingService : public Service {
// Service:
void OnStart() override;
- bool OnConnect(const ServiceInfo& remote_info,
- InterfaceRegistry* registry) override;
void OnBindInterface(const ServiceInfo& remote_info,
const std::string& interface_name,
mojo::ScopedMessagePipeHandle interface_pipe) override;
« no previous file with comments | « services/service_manager/public/cpp/lib/service_test.cc ('k') | services/service_manager/public/cpp/service_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698