content/browser/service_worker/service_worker_context_request_handler.cc - Issue 280423005: Adds class ServiceWorkerScriptCacheMap and new ServiceWorkerVersion::Listener methods related to sc…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_request_handler.cc

Issue 280423005: Adds class ServiceWorkerScriptCacheMap and new ServiceWorkerVersion::Listener methods related to sc… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_core.h ('k') | content/browser/service_worker/service_worker_handle.h » ('j') | content/browser/service_worker/service_worker_script_cache_map.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_context_request_handler.cc b/content/browser/service_worker/service_worker_context_request_handler.cc

index cd6c200f718c6f3c864fec626548ab933a8648d1..2f7ee4ed4bc0d3a8834523432d3309727e85d9bc 100644

--- a/content/browser/service_worker/service_worker_context_request_handler.cc

+++ b/content/browser/service_worker/service_worker_context_request_handler.cc

@@ -60,7 +60,8 @@ bool ServiceWorkerContextRequestHandler::ShouldAddToScriptCache(

// happen prior to the initial eval completion.

if (version_->status() != ServiceWorkerVersion::NEW)

return false;

- return version_->LookupInScriptCache(url) == kInvalidServiceWorkerResponseId;

+ return version_->script_cache_map()->Lookup(url) ==

+ kInvalidServiceWorkerResponseId;

}

bool ServiceWorkerContextRequestHandler::ShouldReadFromScriptCache(

@@ -69,7 +70,7 @@ bool ServiceWorkerContextRequestHandler::ShouldReadFromScriptCache(

if (version_->status() == ServiceWorkerVersion::NEW ||

version_->status() == ServiceWorkerVersion::INSTALLING)

return false;

- *response_id_out = version_->LookupInScriptCache(url);

+ *response_id_out = version_->script_cache_map()->Lookup(url);

return *response_id_out != kInvalidServiceWorkerResponseId;

}