Revert "Redo "dart2js: Insert HTypeKnown refinement nodes on dominated edges of HPhi nodes.""

Revert "Redo "dart2js: Insert HTypeKnown refinement nodes on dominated edges of HPhi nodes.""

There is one case where compilation is much slower (corelib/regexp/pcre_test).
Reverting while investigating.

The test has a 6.6K-line main() with straight-line code.

Before:

    SSA optimizer took 78552msec
    SSA optimizer > SsaInstructionSimplifier took 21434msec
    SSA optimizer > SsaTypeconversionInserter took 12msec
    SSA optimizer > SsaRedundantPhiEliminator took 1msec
    SSA optimizer > SsaDeadPhiEliminator took 0msec
    SSA optimizer > type propagator took 15639msec
    SSA optimizer > SsaCheckInserter took 18msec
    SSA optimizer > SsaDeadCodeEliminator took 35806msec
    SSA optimizer > SsaGlobalValueNumberer took 564msec
    SSA optimizer > SsaCodeMotion took 1msec
    SSA optimizer > SsaLoadElimination took 360msec
    SSA optimizer > SSA value range builder took 4700msec
    SSA optimizer > SsaSimplifyInterceptors took 2msec

After:
    SSA optimizer took 156299msec
    SSA optimizer > SsaInstructionSimplifier took 18700msec
    SSA optimizer > SsaTypeconversionInserter took 7msec
    SSA optimizer > SsaRedundantPhiEliminator took 1msec
    SSA optimizer > SsaDeadPhiEliminator took 0msec
    SSA optimizer > type propagator took 52763msec
    SSA optimizer > SsaCheckInserter took 26msec
    SSA optimizer > SsaDeadCodeEliminator took 31066msec
    SSA optimizer > SsaGlobalValueNumberer took 596msec
    SSA optimizer > SsaCodeMotion took 2msec
    SSA optimizer > SsaLoadElimination took 368msec
    SSA optimizer > SSA value range builder took 52752msec
    SSA optimizer > SsaSimplifyInterceptors took 2msec


BUG=

Committed: https://github.com/dart-lang/sdk/commit/9f10c4898cf6906e0ea341b15da9c285a161c318

[sra1, 2017-04-07 04:54:13]

sra@google.com changed reviewers:
+ efortuna@google.com

[sra1, 2017-04-07 04:55:18]

Description was changed from

==========
Revert "Redo "dart2js: Insert HTypeKnown refinement nodes on dominated edges of
HPhi nodes.""

There is one case where compilation is much slower (corelib/regexp/pcre_test).
Reverting while investigating.

The test has a 6.6K-line main() with straight-line code.

Before:

    SSA optimizer took 78552msec
    SSA optimizer > SsaInstructionSimplifier took 21434msec
    SSA optimizer > SsaTypeconversionInserter took 12msec
    SSA optimizer > SsaRedundantPhiEliminator took 1msec
    SSA optimizer > SsaDeadPhiEliminator took 0msec
    SSA optimizer > type propagator took 15639msec
    SSA optimizer > SsaCheckInserter took 18msec
    SSA optimizer > SsaDeadCodeEliminator took 35806msec
    SSA optimizer > SsaGlobalValueNumberer took 564msec
    SSA optimizer > SsaCodeMotion took 1msec
    SSA optimizer > SsaLoadElimination took 360msec
    SSA optimizer > SSA value range builder took 4700msec
    SSA optimizer > SsaSimplifyInterceptors took 2msec

After:
    SSA optimizer took 156299msec
    SSA optimizer > SsaInstructionSimplifier took 18700msec
    SSA optimizer > SsaTypeconversionInserter took 7msec
    SSA optimizer > SsaRedundantPhiEliminator took 1msec
    SSA optimizer > SsaDeadPhiEliminator took 0msec
    SSA optimizer > type propagator took 52763msec
    SSA optimizer > SsaCheckInserter took 26msec
    SSA optimizer > SsaDeadCodeEliminator took 31066msec
    SSA optimizer > SsaGlobalValueNumberer took 596msec
    SSA optimizer > SsaCodeMotion took 2msec
    SSA optimizer > SsaLoadElimination took 368msec
    SSA optimizer > SSA value range builder took 52752msec
    SSA optimizer > SsaSimplifyInterceptors took 2msec


BUG=
==========

to

==========
Revert "Redo "dart2js: Insert HTypeKnown refinement nodes on dominated edges of
HPhi nodes.""

There is one case where compilation is much slower (corelib/regexp/pcre_test).
Reverting while investigating.

The test has a 6.6K-line main() with straight-line code.

Before:

    SSA optimizer took 78552msec
    SSA optimizer > SsaInstructionSimplifier took 21434msec
    SSA optimizer > SsaTypeconversionInserter took 12msec
    SSA optimizer > SsaRedundantPhiEliminator took 1msec
    SSA optimizer > SsaDeadPhiEliminator took 0msec
    SSA optimizer > type propagator took 15639msec
    SSA optimizer > SsaCheckInserter took 18msec
    SSA optimizer > SsaDeadCodeEliminator took 35806msec
    SSA optimizer > SsaGlobalValueNumberer took 564msec
    SSA optimizer > SsaCodeMotion took 1msec
    SSA optimizer > SsaLoadElimination took 360msec
    SSA optimizer > SSA value range builder took 4700msec
    SSA optimizer > SsaSimplifyInterceptors took 2msec

After:
    SSA optimizer took 156299msec
    SSA optimizer > SsaInstructionSimplifier took 18700msec
    SSA optimizer > SsaTypeconversionInserter took 7msec
    SSA optimizer > SsaRedundantPhiEliminator took 1msec
    SSA optimizer > SsaDeadPhiEliminator took 0msec
    SSA optimizer > type propagator took 52763msec
    SSA optimizer > SsaCheckInserter took 26msec
    SSA optimizer > SsaDeadCodeEliminator took 31066msec
    SSA optimizer > SsaGlobalValueNumberer took 596msec
    SSA optimizer > SsaCodeMotion took 2msec
    SSA optimizer > SsaLoadElimination took 368msec
    SSA optimizer > SSA value range builder took 52752msec
    SSA optimizer > SsaSimplifyInterceptors took 2msec


BUG=

Committed:
https://github.com/dart-lang/sdk/commit/9f10c4898cf6906e0ea341b15da9c285a161c318
==========

[sra1, 2017-04-07 04:55:19]

Committed patchset #1 (id:1) manually as
9f10c4898cf6906e0ea341b15da9c285a161c318 (presubmit successful).

[Emily Fortuna, 2017-04-10 18:04:33]

lgtm :-/