Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5105)

Unified Diff: chrome/browser/chromeos/events/event_rewriter_unittest.cc

Issue 280413002: Fix handling of rewritten-Alt + Button1 -> Button3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unit test Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/events/event_rewriter_unittest.cc
diff --git a/chrome/browser/chromeos/events/event_rewriter_unittest.cc b/chrome/browser/chromeos/events/event_rewriter_unittest.cc
index 3c6ce722626d60e6706015ad44273c818027dd2e..667db31a814be773bbc8cc0c01cd7db15ae025f3 100644
--- a/chrome/browser/chromeos/events/event_rewriter_unittest.cc
+++ b/chrome/browser/chromeos/events/event_rewriter_unittest.cc
@@ -1467,6 +1467,39 @@ TEST_F(EventRewriterAshTest, TopRowKeysAreFunctionKeys) {
*static_cast<const ui::KeyEvent*>(rewritten_event.get())));
}
+TEST_F(EventRewriterTest, TestRewrittenModifierClick) {
+ std::vector<unsigned int> device_list;
+ device_list.push_back(10);
+ ui::TouchFactory::GetInstance()->SetPointerDeviceForTest(device_list);
+
+ // Remap Control to Alt.
+ TestingPrefServiceSyncable prefs;
+ chromeos::Preferences::RegisterProfilePrefs(prefs.registry());
+ IntegerPrefMember control;
+ control.Init(prefs::kLanguageRemapControlKeyTo, &prefs);
+ control.SetValue(chromeos::input_method::kAltKey);
+
+ EventRewriter rewriter;
+ rewriter.set_pref_service_for_testing(&prefs);
+
+ // Check that Control + Left Button is converted (via Alt + Left Button)
+ // to Right Button.
+ ui::ScopedXI2Event xev;
+ xev.InitGenericButtonEvent(10,
+ ui::ET_MOUSE_PRESSED,
+ gfx::Point(),
+ ui::EF_LEFT_MOUSE_BUTTON | ui::EF_CONTROL_DOWN);
+ ui::MouseEvent press(xev);
+ // Sanity check.
+ EXPECT_EQ(ui::ET_MOUSE_PRESSED, press.type());
+ EXPECT_EQ(ui::EF_LEFT_MOUSE_BUTTON | ui::EF_CONTROL_DOWN, press.flags());
+ int flags = RewriteMouseEvent(&rewriter, press);
+ EXPECT_TRUE(ui::EF_RIGHT_MOUSE_BUTTON & flags);
+ EXPECT_FALSE(ui::EF_CONTROL_DOWN & flags);
+ EXPECT_FALSE(ui::EF_ALT_DOWN & flags);
+}
+
+
TEST_F(EventRewriterTest, DontRewriteIfNotRewritten) {
std::vector<unsigned int> device_list;
device_list.push_back(10);

Powered by Google App Engine
This is Rietveld 408576698