Various page_load_metrics cleanups and improvements

chrome/browser/page_load_metrics/page_load_tracker.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_TRACKER_H_
 #define CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_TRACKER_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 37 matching lines @@
 // These errors are internal to the page_load_metrics subsystem and do not
 // reflect actual errors that occur during a page load.
 //
 // If you add elements to this enum, make sure you update the enum
 // value in histograms.xml. Only add elements to the end to prevent
 // inconsistencies between versions.
 enum InternalErrorLoadEvent {
   // A timing IPC was sent from the renderer that did not line up with previous
   // data we've received (i.e. navigation start is different or the timing
   // struct is somehow invalid). This error can only occur once the IPC is
-  // vetted in other ways (see other errors).
-  ERR_BAD_TIMING_IPC,
+  // vetted in other ways (see other errors). This error is deprecated as it has
+  // been replaced by the more detailed ERR_BAD_TIMING_IPC_* error codes.
+  DEPRECATED_ERR_BAD_TIMING_IPC,
 
   // The following IPCs are not mutually exclusive.
   //
   // We received an IPC when we weren't tracking a committed load. This will
   // often happen if we get an IPC from a bad URL scheme (that is, the renderer
   // sent us an IPC from a navigation we don't care about).
   ERR_IPC_WITH_NO_RELEVANT_LOAD,
 
   // Received a notification from a frame that has been navigated away from.
   ERR_IPC_FROM_WRONG_FRAME,
@@ skipping 34 matching lines @@
   // At the time a PageLoadTracker was destroyed, we had received neither a
   // commit nor a failed provisional load.
   ERR_NO_COMMIT_OR_FAILED_PROVISIONAL_LOAD,
 
   // No page load end time was recorded for this page load.
   ERR_NO_PAGE_LOAD_END_TIME,
 
   // Received a timing update from a subframe.
   ERR_TIMING_IPC_FROM_SUBFRAME,
 
+  // A timing IPC was sent from the renderer that contained timing data which
+  // was inconsistent with our timing data for the currently committed load.
+  ERR_BAD_TIMING_IPC_INVALID_TIMING_DESCENDENT,
+
+  // A timing IPC was sent from the renderer that contained loading behavior
+  // data which was inconsistent with our loading behavior data for the
+  // currently committed load.
+  ERR_BAD_TIMING_IPC_INVALID_BEHAVIOR_DESCENDENT,
+
+  // A timing IPC was sent from the renderer that contained invalid timing data
+  // (e.g. out of order timings, or other issues).
+  ERR_BAD_TIMING_IPC_INVALID_TIMING,
+
   // Add values before this final count.
   ERR_LAST_ENTRY,
 };
 
 // NOTE: these functions are shared by page_load_tracker.cc and
 // metrics_web_contents_observer.cc. They are declared here to allow both files
 // to access them.
 void RecordInternalError(InternalErrorLoadEvent event);
 PageEndReason EndReasonForPageTransition(ui::PageTransition transition);
 void LogAbortChainSameURLHistogram(int aborted_chain_size_same_url);
@@ skipping 29 matching lines @@
   void OnInputEvent(const blink::WebInputEvent& event);
 
   // Flush any buffered metrics, as part of the metrics subsystem persisting
   // metrics as the application goes into the background. The application may be
   // killed at any time after this method is invoked without further
   // notification.
   void FlushMetricsOnAppEnterBackground();
 
   void NotifyClientRedirectTo(const PageLoadTracker& destination);
 
-  // Returns true if the timing was successfully updated.
-  bool UpdateTiming(const PageLoadTiming& timing,
+  void UpdateTiming(const PageLoadTiming& timing,
                     const PageLoadMetadata& metadata);
 
   // Update metadata for child frames. Updates for child frames arrive
   // separately from updates for the main frame, so aren't included in
   // UpdateTiming.
   void UpdateChildFrameMetadata(const PageLoadMetadata& child_metadata);
 
   void OnLoadedResource(const ExtraRequestInfo& extra_request_info);
 
   // Signals that we should stop tracking metrics for the associated page load.
@@ skipping 159 matching lines @@
   PageLoadMetricsEmbedderInterface* const embedder_interface_;
 
   std::vector<std::unique_ptr<PageLoadMetricsObserver>> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(PageLoadTracker);
 };
 
 }  // namespace page_load_metrics
 
 #endif  // CHROME_BROWSER_PAGE_LOAD_METRICS_PAGE_LOAD_TRACKER_H_