Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2804053002: [Devtools] Move request blocking out of experiments (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 1100 matching lines...) Expand 10 before | Expand all | Expand 10 after
1111 } 1111 }
1112 copyMenu.appendItem(Common.UIString.capitalize('Copy ^all as HAR'), this._co pyAll.bind(this)); 1112 copyMenu.appendItem(Common.UIString.capitalize('Copy ^all as HAR'), this._co pyAll.bind(this));
1113 1113
1114 contextMenu.appendSeparator(); 1114 contextMenu.appendSeparator();
1115 contextMenu.appendItem(Common.UIString.capitalize('Save as HAR with ^content '), this._exportAll.bind(this)); 1115 contextMenu.appendItem(Common.UIString.capitalize('Save as HAR with ^content '), this._exportAll.bind(this));
1116 1116
1117 contextMenu.appendSeparator(); 1117 contextMenu.appendSeparator();
1118 contextMenu.appendItem(Common.UIString.capitalize('Clear ^browser ^cache'), this._clearBrowserCache.bind(this)); 1118 contextMenu.appendItem(Common.UIString.capitalize('Clear ^browser ^cache'), this._clearBrowserCache.bind(this));
1119 contextMenu.appendItem(Common.UIString.capitalize('Clear ^browser ^cookies') , this._clearBrowserCookies.bind(this)); 1119 contextMenu.appendItem(Common.UIString.capitalize('Clear ^browser ^cookies') , this._clearBrowserCookies.bind(this));
1120 1120
1121 if (request && Runtime.experiments.isEnabled('requestBlocking')) { // Disab led until ready. 1121 if (request) { // Disabled until ready.
dgozman 2017/04/06 19:28:16 Wrong comment.
allada 2017/04/07 18:21:26 Done.
1122 contextMenu.appendSeparator(); 1122 contextMenu.appendSeparator();
1123 1123
1124 var blockedSetting = Common.moduleSetting('networkBlockedURLs'); 1124 var blockedSetting = Common.moduleSetting('networkBlockedURLs');
1125 var blockedSettingData = blockedSetting.get(); 1125 var blockedSettingData = blockedSetting.get();
1126 1126
1127 const maxBlockedURLLength = 20; 1127 const maxBlockedURLLength = 20;
1128 var urlWithoutScheme = request.parsedURL.urlWithoutScheme(); 1128 var urlWithoutScheme = request.parsedURL.urlWithoutScheme();
1129 var blockedURLIndex = blockedSettingData.indexOf(urlWithoutScheme); 1129 var blockedURLIndex = blockedSettingData.indexOf(urlWithoutScheme);
1130 if (urlWithoutScheme && blockedURLIndex === -1) { 1130 if (urlWithoutScheme && blockedURLIndex === -1) {
1131 contextMenu.appendItem( 1131 contextMenu.appendItem(
(...skipping 680 matching lines...) Expand 10 before | Expand all | Expand 10 after
1812 * @return {?*} 1812 * @return {?*}
1813 */ 1813 */
1814 groupForRequest(request) {}, 1814 groupForRequest(request) {},
1815 1815
1816 /** 1816 /**
1817 * @param {!*} key 1817 * @param {!*} key
1818 * @return {string} 1818 * @return {string}
1819 */ 1819 */
1820 groupName(key) {} 1820 groupName(key) {}
1821 }; 1821 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698