chrome/android/junit/src/org/chromium/chrome/browser/init/AsyncInitTaskRunnerTest.java - Issue 2804043002: Enable variations restrict param for Java-side fetches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/init/AsyncInitTaskRunnerTest.java

Issue 2804043002: Enable variations restrict param for Java-side fetches. (Closed)

Patch Set: Addressed comments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/metrics/VariationsSession.java ('K') | « chrome/android/java_sources.gni ('k') | chrome/android/junit/src/org/chromium/chrome/browser/metrics/VariationsSessionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/init/AsyncInitTaskRunnerTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/init/AsyncInitTaskRunnerTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/init/AsyncInitTaskRunnerTest.java

index 5835abf81e2590c83fd11426d899a2f4a3f1192e..34fb48c076effcb04e34d99332e74fa7f85b2661 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/init/AsyncInitTaskRunnerTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/init/AsyncInitTaskRunnerTest.java

@@ -86,7 +86,7 @@ public class AsyncInitTaskRunnerTest {

verify(mLoader).ensureInitialized();

verify(mLoader).asyncPrefetchLibrariesToMemory();

verify(mRunner).onSuccess();

- verify(mVariationsSeedFetcher, never()).fetchSeed();

+ verify(mVariationsSeedFetcher, never()).fetchSeed("");

}

@Test

@@ -100,7 +100,7 @@ public class AsyncInitTaskRunnerTest {

Robolectric.flushForegroundThreadScheduler();

assertTrue(mLatch.await(0, TimeUnit.SECONDS));

verify(mRunner).onFailure();

- verify(mVariationsSeedFetcher, never()).fetchSeed();

+ verify(mVariationsSeedFetcher, never()).fetchSeed("");

}

@Test

@@ -113,7 +113,7 @@ public class AsyncInitTaskRunnerTest {

verify(mLoader).ensureInitialized();

verify(mLoader).asyncPrefetchLibrariesToMemory();

verify(mRunner).onSuccess();

- verify(mVariationsSeedFetcher).fetchSeed();

+ verify(mVariationsSeedFetcher).fetchSeed("");

}

// TODO(aberent) Test for allocateChildConnection. Needs refactoring of ChildProcessLauncher to