chrome/browser/cocoa/translate/before_translate_infobar_controller.mm - Issue 2804035: Clean up mac translate bars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/translate/before_translate_infobar_controller.mm

Issue 2804035: Clean up mac translate bars. (Closed)

Patch Set: Fixes. Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/cocoa/translate/after_translate_infobar_controller.mm ('k') | chrome/browser/cocoa/translate/translate_infobar_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/cocoa/translate/before_translate_infobar_controller.mm

diff --git a/chrome/browser/cocoa/translate/before_translate_infobar_controller.mm b/chrome/browser/cocoa/translate/before_translate_infobar_controller.mm

index d2d418d90b3c55d7f129d5830944fb50e5fa2a55..bcae753bc2f07679ad1bc24ec1ecbb93b37a3ff4 100644

--- a/chrome/browser/cocoa/translate/before_translate_infobar_controller.mm

+++ b/chrome/browser/cocoa/translate/before_translate_infobar_controller.mm

@@ -9,13 +9,13 @@

#include "grit/generated_resources.h"

using TranslateInfoBarUtilities::MoveControl;

+using TranslateInfoBarUtilities::VerifyControlOrderAndSpacing;

@implementation BeforeTranslateInfobarController

- (void)layout {

- [optionsPopUp_ setHidden:NO];

- MoveControl(label1_, fromLanguagePopUp_, 0, true);

- MoveControl(fromLanguagePopUp_, label2_, 0, true);

+ MoveControl(label1_, fromLanguagePopUp_, spaceBetweenControls_ / 2, true);

+ MoveControl(fromLanguagePopUp_, label2_, spaceBetweenControls_, true);

MoveControl(label2_, okButton_, spaceBetweenControls_, true);

MoveControl(okButton_, cancelButton_, spaceBetweenControls_, true);

}

@@ -35,7 +35,6 @@ using TranslateInfoBarUtilities::MoveControl;

- (NSArray*)visibleControls {

return [NSArray arrayWithObjects:label1_.get(), fromLanguagePopUp_.get(),

label2_.get(), okButton_, cancelButton_, nil];

}

- (bool)verifyLayout {