Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 280403005: Always inline Filter_32_*_neon functions (Closed)

Created:
6 years, 7 months ago by Kimmo Kinnunen
Modified:
6 years, 7 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Always inline Filter_32_*_neon functions The functions are rather performance critical and already marked 'inline'. However, Chrome for Android will not have these functions inlined due to it being compiled with -Os and a small -finline-limit. This avoids one call in the filtering functions. Does not increase the library size. BUG=chromium:363073 Committed: http://code.google.com/p/skia/source/detail?r=14709

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M src/opts/SkBitmapProcState_filter_neon.h View 1 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Kimmo Kinnunen
6 years, 7 months ago (2014-05-13 11:54:58 UTC) #1
mtklein
Can you add a note in here somewhere to remind us why we force inlining? ...
6 years, 7 months ago (2014-05-13 12:10:17 UTC) #2
Kimmo Kinnunen
On 2014/05/13 12:10:17, mtklein wrote: > Can you add a note in here somewhere to ...
6 years, 7 months ago (2014-05-13 12:25:37 UTC) #3
mtklein
lgtm
6 years, 7 months ago (2014-05-13 12:28:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kkinnunen@nvidia.com/280403005/20001
6 years, 7 months ago (2014-05-13 12:28:39 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 14:47:14 UTC) #6
Message was sent while issue was closed.
Change committed as 14709

Powered by Google App Engine
This is Rietveld 408576698