Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Side by Side Diff: chrome/browser/prerender/external_prerender_handler_android.cc

Issue 280403002: Only commit cookie changes in prerenders after a prerender is shown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: fix sync related bug Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prerender/external_prerender_handler_android.h" 5 #include "chrome/browser/prerender/external_prerender_handler_android.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 return false; 82 return false;
83 prerender::PrerenderManager* prerender_manager = 83 prerender::PrerenderManager* prerender_manager =
84 prerender::PrerenderManagerFactory::GetForProfile(profile); 84 prerender::PrerenderManagerFactory::GetForProfile(profile);
85 if (!prerender_manager) 85 if (!prerender_manager)
86 return false; 86 return false;
87 content::WebContents* web_contents = 87 content::WebContents* web_contents =
88 reinterpret_cast<content::WebContents*>(web_contents_ptr); 88 reinterpret_cast<content::WebContents*>(web_contents_ptr);
89 return prerender_manager->HasPrerenderedUrl(url, web_contents); 89 return prerender_manager->HasPrerenderedUrl(url, web_contents);
90 } 90 }
91 91
92 static jboolean HasCookieStoreLoaded(JNIEnv* env,
93 jclass clazz,
94 jobject jprofile) {
95 Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile);
96 prerender::PrerenderManager* prerender_manager =
97 prerender::PrerenderManagerFactory::GetForProfile(profile);
98 if (!prerender_manager)
99 return false;
100 return prerender_manager->cookie_store_loaded();
101 }
102
92 ExternalPrerenderHandlerAndroid::ExternalPrerenderHandlerAndroid() {} 103 ExternalPrerenderHandlerAndroid::ExternalPrerenderHandlerAndroid() {}
93 104
94 ExternalPrerenderHandlerAndroid::~ExternalPrerenderHandlerAndroid() {} 105 ExternalPrerenderHandlerAndroid::~ExternalPrerenderHandlerAndroid() {}
95 106
96 static jlong Init(JNIEnv* env, jclass clazz) { 107 static jlong Init(JNIEnv* env, jclass clazz) {
97 ExternalPrerenderHandlerAndroid* external_handler = 108 ExternalPrerenderHandlerAndroid* external_handler =
98 new ExternalPrerenderHandlerAndroid(); 109 new ExternalPrerenderHandlerAndroid();
99 return reinterpret_cast<intptr_t>(external_handler); 110 return reinterpret_cast<intptr_t>(external_handler);
100 } 111 }
101 112
102 bool ExternalPrerenderHandlerAndroid::RegisterExternalPrerenderHandlerAndroid( 113 bool ExternalPrerenderHandlerAndroid::RegisterExternalPrerenderHandlerAndroid(
103 JNIEnv* env) { 114 JNIEnv* env) {
104 return RegisterNativesImpl(env); 115 return RegisterNativesImpl(env);
105 } 116 }
106 117
107 } // namespace prerender 118 } // namespace prerender
OLDNEW
« no previous file with comments | « chrome/browser/prerender/external_prerender_handler_android.h ('k') | chrome/browser/prerender/prerender_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698