Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: third_party/WebKit/Source/modules/fetch/RequestTest.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Use DCHECK_EQ in all but a few instances Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/RequestTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/RequestTest.cpp b/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
index b7d135f1070aa7d4021ac2d48094a5b981fa0c58..b94e41e18b2aaebc0ba485718d1fc81031d5355b 100644
--- a/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
@@ -26,7 +26,7 @@ TEST(ServiceWorkerRequestTest, FromString) {
Request* request =
Request::Create(scope.GetScriptState(), url, exception_state);
ASSERT_FALSE(exception_state.HadException());
- ASSERT(request);
+ DCHECK(request);
EXPECT_EQ(url, request->url());
}
@@ -37,12 +37,12 @@ TEST(ServiceWorkerRequestTest, FromRequest) {
KURL url(kParsedURLString, "http://www.example.com/");
Request* request1 =
Request::Create(scope.GetScriptState(), url, exception_state);
- ASSERT(request1);
+ DCHECK(request1);
Request* request2 =
Request::Create(scope.GetScriptState(), request1, exception_state);
ASSERT_FALSE(exception_state.HadException());
- ASSERT(request2);
+ DCHECK(request2);
EXPECT_EQ(url, request2->url());
}
@@ -73,7 +73,7 @@ TEST(ServiceWorkerRequestTest, FromAndToWebRequest) {
web_request.SetReferrer(referrer, kReferrerPolicy);
Request* request = Request::Create(scope.GetScriptState(), web_request);
- ASSERT(request);
+ DCHECK(request);
EXPECT_EQ(url, request->url());
EXPECT_EQ(method, request->method());
EXPECT_EQ("audio", request->Context());
@@ -111,7 +111,7 @@ TEST(ServiceWorkerRequestTest, ToWebRequestStripsURLFragment) {
String url = url_without_fragment + "#fragment";
Request* request =
Request::Create(scope.GetScriptState(), url, exception_state);
- ASSERT(request);
+ DCHECK(request);
WebServiceWorkerRequest web_request;
request->PopulateWebServiceWorkerRequest(web_request);
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Request.cpp ('k') | third_party/WebKit/Source/modules/fetch/Response.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698