Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: third_party/WebKit/Source/modules/fetch/Headers.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Use DCHECK_EQ in all but a few instances Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/Headers.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/Headers.cpp b/third_party/WebKit/Source/modules/fetch/Headers.cpp
index a62a64039ad13f424c71cb58450623f16673d31a..13899221afe4eb1bb4ea80058a18cd23b9e04c2b 100644
--- a/third_party/WebKit/Source/modules/fetch/Headers.cpp
+++ b/third_party/WebKit/Source/modules/fetch/Headers.cpp
@@ -238,7 +238,7 @@ void Headers::set(const String& name,
}
void Headers::FillWith(const Headers* object, ExceptionState& exception_state) {
- ASSERT(header_list_->size() == 0);
+ DCHECK(header_list_->size() == 0);
// There used to be specific steps describing filling a Headers object with
// another Headers object, but it has since been removed because it should be
// handled like a sequence (http://crbug.com/690428).
@@ -252,7 +252,7 @@ void Headers::FillWith(const Headers* object, ExceptionState& exception_state) {
void Headers::FillWith(const Vector<Vector<String>>& object,
ExceptionState& exception_state) {
- ASSERT(!header_list_->size());
+ DCHECK(!header_list_->size());
// "1. If |object| is a sequence, then for each |header| in |object|, run
// these substeps:
// 1. If |header| does not contain exactly two items, then throw a
@@ -272,7 +272,7 @@ void Headers::FillWith(const Vector<Vector<String>>& object,
void Headers::FillWith(const Vector<std::pair<String, String>>& object,
ExceptionState& exception_state) {
- ASSERT(!header_list_->size());
+ DCHECK(!header_list_->size());
for (const auto& item : object) {
append(item.first, item.second, exception_state);
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp ('k') | third_party/WebKit/Source/modules/fetch/Request.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698