Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

Issue 2804023004: Replace ASSERT with DCHECK in modules/fetch. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
index 828b6d0e8fa1d1c60f7180255f5e14cfc8c774bd..9a0b75a26b040743fafc8b62bf5725e11cc42ac3 100644
--- a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
+++ b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
@@ -124,8 +124,8 @@ ScriptValue BodyStreamBuffer::stream() {
PassRefPtr<BlobDataHandle> BodyStreamBuffer::drainAsBlobDataHandle(
BytesConsumer::BlobSizePolicy policy) {
- ASSERT(!isStreamLocked());
- ASSERT(!isStreamDisturbed());
+ DCHECK(!isStreamLocked());
+ DCHECK(!isStreamDisturbed());
if (isStreamClosed() || isStreamErrored())
return nullptr;
@@ -142,8 +142,8 @@ PassRefPtr<BlobDataHandle> BodyStreamBuffer::drainAsBlobDataHandle(
}
PassRefPtr<EncodedFormData> BodyStreamBuffer::drainAsFormData() {
- ASSERT(!isStreamLocked());
- ASSERT(!isStreamDisturbed());
+ DCHECK(!isStreamLocked());
+ DCHECK(!isStreamDisturbed());
if (isStreamClosed() || isStreamErrored())
return nullptr;
@@ -160,8 +160,8 @@ PassRefPtr<EncodedFormData> BodyStreamBuffer::drainAsFormData() {
void BodyStreamBuffer::startLoading(FetchDataLoader* loader,
FetchDataLoader::Client* client) {
- ASSERT(!m_loader);
- ASSERT(m_scriptState->contextIsValid());
+ DCHECK(!m_loader);
+ DCHECK(m_scriptState->contextIsValid());
m_loader = loader;
loader->start(
releaseHandle(),
@@ -192,7 +192,7 @@ void BodyStreamBuffer::tee(BodyStreamBuffer** branch1,
}
ScriptPromise BodyStreamBuffer::pull(ScriptState* scriptState) {
- ASSERT(scriptState == m_scriptState.get());
+ DCHECK(scriptState == m_scriptState.get());
tkent 2017/04/08 02:29:54 Use DCHECK_EQ if it doesn't cause a build failure.
if (m_streamNeedsMore)
return ScriptPromise::castUndefined(scriptState);
m_streamNeedsMore = true;
@@ -202,7 +202,7 @@ ScriptPromise BodyStreamBuffer::pull(ScriptState* scriptState) {
ScriptPromise BodyStreamBuffer::cancel(ScriptState* scriptState,
ScriptValue reason) {
- ASSERT(scriptState == m_scriptState.get());
+ DCHECK(scriptState == m_scriptState.get());
tkent 2017/04/08 02:29:54 Use DCHECK_EQ if it doesn't cause a build failure.
close();
return ScriptPromise::castUndefined(scriptState);
}
@@ -339,7 +339,7 @@ void BodyStreamBuffer::processData() {
}
void BodyStreamBuffer::endLoading() {
- ASSERT(m_loader);
+ DCHECK(m_loader);
m_loader = nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698