Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2803973002: Support dartk on Windows. (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support dartk on Windows. This adds tools/dartk_wrappers/dartk.bat. The --package argument is deliberately relative because of issue 29284. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/12615de38fb56203049f9f59eb3128bd96b6760d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
M tests/compiler/dart2js/dill_loader_test.dart View 2 chunks +12 lines, -11 lines 0 comments Download
A tools/dartk_wrappers/dartk.bat View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-06 13:10:42 UTC) #2
asgerf
lgtm
3 years, 8 months ago (2017-04-06 14:52:42 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-04-07 07:31:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
12615de38fb56203049f9f59eb3128bd96b6760d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698