chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc - Issue 2803963002: Don't kill Chrome Apps that make XHRs from guests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

Issue 2803963002: Don't kill Chrome Apps that make XHRs from guests. (Closed)

Patch Set: Fix comments from review. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/guest_view/web_view_browsertest.cc ('k') | chrome/test/data/extensions/platform_apps/web_view/content_script_fetch/content_script.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

diff --git a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

index 6bf45963aa2b568c9e7217d0440f37e4599cdb8b..b24d804cd553b4fae70e9d903e822226f4048343 100644

--- a/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

+++ b/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc

@@ -207,9 +207,10 @@ content::HeaderInterceptorResult CheckOriginHeader(

const ProcessMap& process_map = extension_info_map->process_map();

if (extension->is_platform_app() &&

!process_map.Contains(extension->id(), child_id)) {

- // This is a platform app origin not in the app's own process. If there

- // are no accessible resources, this is illegal.

- if (!extension->GetManifestData(manifest_keys::kWebviewAccessibleResources))

+ // This is a platform app origin not in the app's own process. If it cannot

+ // create webviews, this is illegal.

+ if (!extension->permissions_data()->HasAPIPermission(

+ extensions::APIPermission::kWebView))

return content::HeaderInterceptorResult::KILL;

// If there are accessible resources, the origin is only legal if the