[Media Router] Unload the legacy Cast extension at install

chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/media/router/media_router_feature.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h"
 #include "chrome/browser/ui/toolbar/toolbar_actions_bar.h"
 #include "extensions/browser/extension_registry.h"
+#include "extensions/browser/extension_system.h"
 
 #if defined(ENABLE_MEDIA_ROUTER)
 #include "chrome/browser/ui/toolbar/media_router_action.h"
 #include "chrome/browser/ui/toolbar/media_router_action_controller.h"
 #endif
 
 // static
 const char ComponentToolbarActionsFactory::kCastBetaExtensionId[] =
     "dliochdbjfkdbacpmhlcpmleaejidimm";
 const char ComponentToolbarActionsFactory::kCastExtensionId[] =
     "boadgeojelhgndaghljhdicfkmllpafd";
 const char ComponentToolbarActionsFactory::kMediaRouterActionId[] =
     "media_router_action";
 
 ComponentToolbarActionsFactory::ComponentToolbarActionsFactory(Profile* profile)
-    : profile_(profile) {
+    : profile_(profile),
+      extension_registry_(extensions::ExtensionRegistry::Get(profile)),
+      extension_system_(extensions::ExtensionSystem::Get(profile)),
+      extension_registry_observer_(this) {
 #if defined(ENABLE_MEDIA_ROUTER)
   if (media_router::MediaRouterEnabled(profile_) &&
       MediaRouterActionController::IsActionShownByPolicy(profile_)) {
     initial_ids_.insert(kMediaRouterActionId);
   }
 #endif
+  extension_registry_observer_.Add(extensions::ExtensionRegistry::Get(profile));
 }
 
 ComponentToolbarActionsFactory::~ComponentToolbarActionsFactory() {}
 
 std::set<std::string> ComponentToolbarActionsFactory::GetInitialComponentIds() {
   return initial_ids_;
 }
 
 void ComponentToolbarActionsFactory::OnAddComponentActionBeforeInit(
     const std::string& action_id) {
@@ skipping 19 matching lines @@
 #if defined(ENABLE_MEDIA_ROUTER)
   if (action_id == kMediaRouterActionId)
     return std::unique_ptr<ToolbarActionViewController>(
         new MediaRouterAction(browser, bar));
 #endif  // defined(ENABLE_MEDIA_ROUTER)
 
   NOTREACHED();
   return std::unique_ptr<ToolbarActionViewController>();
 }
 
-void ComponentToolbarActionsFactory::UnloadMigratedExtensions(
-    ExtensionService* service,
-    extensions::ExtensionRegistry* registry) {
-  // TODO(takumif): Replace the unloading of Cast and Cast Beta extensions with
-  // uninstallation.
-  UnloadExtension(service, registry, kCastExtensionId);
-  UnloadExtension(service, registry, kCastBetaExtensionId);
+void ComponentToolbarActionsFactory::UnloadMigratedExtensions() {
+  UnloadExtension(kCastExtensionId);
+  UnloadExtension(kCastBetaExtensionId);
+}
+
+void ComponentToolbarActionsFactory::OnExtensionInstalled(
+    content::BrowserContext* browser_context,
+    const extensions::Extension* extension,
+    bool is_update) {
+  if (extension->id() == kCastExtensionId ||
+      extension->id() == kCastBetaExtensionId) {
+    UnloadExtension(extension->id());
+  }
 }
 
 void ComponentToolbarActionsFactory::UnloadExtension(
-    ExtensionService* service,
-    extensions::ExtensionRegistry* registry,
     const std::string& extension_id) {
-  if (registry->enabled_extensions().Contains(extension_id)) {
-    service->UnloadExtension(
+  if (extension_registry_->GenerateInstalledExtensionsSet()->Contains(
+          extension_id)) {
+    DCHECK(extension_system_->extension_service());
+    extension_system_->extension_service()->UnloadExtension(
         extension_id,
         extensions::UnloadedExtensionInfo::REASON_MIGRATED_TO_COMPONENT);
   }
 }