Revert of [snapshot] Move builtins generation into mksnapshot

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/arm.gni")
 import("//build/config/dcheck_always_on.gni")
 import("//build/config/mips.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 
@@ skipping 791 matching lines @@
     public_deps = [
       ":v8_external_snapshot",
     ]
   } else if (v8_use_snapshot) {
     public_deps = [
       ":v8_snapshot",
     ]
   } else {
     # Ignore v8_use_external_startup_data setting if no snapshot is used.
     public_deps = [
-      ":v8_builtins_setup",
       ":v8_nosnapshot",
     ]
   }
 }
 
 v8_source_set("v8_nosnapshot") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   deps = [
     ":js2c",
     ":js2c_experimental_extras",
     ":js2c_extras",
     ":v8_base",
+    ":v8_builtins_generators",
   ]
 
   sources = [
     "$target_gen_dir/experimental-extras-libraries.cc",
     "$target_gen_dir/extras-libraries.cc",
     "$target_gen_dir/libraries.cc",
     "src/snapshot/snapshot-empty.cc",
   ]
 
   configs = [ ":internal_config" ]
 }
 
 v8_source_set("v8_snapshot") {
   # Only targets in this file and the top-level visibility target can
   # depend on this.
   visibility = [
     ":*",
     "//:gn_visibility",
   ]
 
   deps = [
     ":js2c",
     ":js2c_experimental_extras",
     ":js2c_extras",
     ":v8_base",
+    ":v8_builtins_generators",
   ]
   public_deps = [
     # This should be public so downstream targets can declare the snapshot
     # output file as their inputs.
     ":run_mksnapshot",
   ]
 
   sources = [
     "$target_gen_dir/experimental-extras-libraries.cc",
     "$target_gen_dir/extras-libraries.cc",
     "$target_gen_dir/libraries.cc",
     "$target_gen_dir/snapshot.cc",
-    "src/setup-isolate-deserialize.cc",
   ]
 
   configs = [ ":internal_config" ]
 }
 
 if (v8_use_external_startup_data) {
   v8_source_set("v8_external_snapshot") {
     visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
     deps = [
       ":js2c",
       ":js2c_experimental_extras",
       ":js2c_extras",
       ":v8_base",
+      ":v8_builtins_generators",
     ]
     public_deps = [
       ":natives_blob",
       ":run_mksnapshot",
     ]
 
     sources = [
-      "src/setup-isolate-deserialize.cc",
       "src/snapshot/natives-external.cc",
       "src/snapshot/snapshot-external.cc",
     ]
 
     configs = [ ":internal_config" ]
   }
 }
 
 v8_source_set("v8_builtins_generators") {
-  visibility = [
-    ":*",
-    "test/cctest:*",
-    "test/unittests:*",
-  ]
+  visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   deps = [
     ":v8_base",
   ]
 
   sources = [
     ### gcmole(all) ###
     "src/builtins/builtins-arguments-gen.cc",
     "src/builtins/builtins-arguments-gen.h",
     "src/builtins/builtins-array-gen.cc",
     "src/builtins/builtins-async-function-gen.cc",
     "src/builtins/builtins-async-gen.cc",
     "src/builtins/builtins-async-gen.h",
     "src/builtins/builtins-async-generator-gen.cc",
     "src/builtins/builtins-async-iterator-gen.cc",
     "src/builtins/builtins-boolean-gen.cc",
-    "src/builtins/builtins-call-gen.cc",
     "src/builtins/builtins-constructor-gen.cc",
     "src/builtins/builtins-constructor-gen.h",
     "src/builtins/builtins-constructor.h",
     "src/builtins/builtins-conversion-gen.cc",
     "src/builtins/builtins-date-gen.cc",
     "src/builtins/builtins-forin-gen.cc",
     "src/builtins/builtins-forin-gen.h",
     "src/builtins/builtins-function-gen.cc",
     "src/builtins/builtins-generator-gen.cc",
     "src/builtins/builtins-global-gen.cc",
     "src/builtins/builtins-handler-gen.cc",
     "src/builtins/builtins-ic-gen.cc",
     "src/builtins/builtins-internal-gen.cc",
-    "src/builtins/builtins-interpreter-gen.cc",
     "src/builtins/builtins-math-gen.cc",
     "src/builtins/builtins-number-gen.cc",
     "src/builtins/builtins-object-gen.cc",
     "src/builtins/builtins-promise-gen.cc",
     "src/builtins/builtins-promise-gen.h",
     "src/builtins/builtins-regexp-gen.cc",
     "src/builtins/builtins-regexp-gen.h",
     "src/builtins/builtins-sharedarraybuffer-gen.cc",
     "src/builtins/builtins-string-gen.cc",
     "src/builtins/builtins-symbol-gen.cc",
     "src/builtins/builtins-typedarray-gen.cc",
     "src/builtins/builtins-utils-gen.h",
     "src/builtins/builtins-wasm-gen.cc",
-    "src/builtins/setup-builtins-internal.cc",
     "src/ic/accessor-assembler.cc",
     "src/ic/accessor-assembler.h",
     "src/ic/binary-op-assembler.cc",
     "src/ic/binary-op-assembler.h",
     "src/ic/keyed-store-generic.cc",
     "src/ic/keyed-store-generic.h",
     "src/interpreter/interpreter-assembler.cc",
     "src/interpreter/interpreter-assembler.h",
     "src/interpreter/interpreter-generator.cc",
     "src/interpreter/interpreter-generator.h",
     "src/interpreter/interpreter-intrinsics-generator.cc",
     "src/interpreter/interpreter-intrinsics-generator.h",
-    "src/interpreter/setup-interpreter-internal.cc",
-    "src/interpreter/setup-interpreter.h",
   ]
 
   if (v8_current_cpu == "x86") {
     sources += [
       ### gcmole(arch:ia32) ###
       "src/builtins/ia32/builtins-ia32.cc",
     ]
   } else if (v8_current_cpu == "x64") {
     sources += [
       ### gcmole(arch:x64) ###
@@ skipping 32 matching lines @@
   } else if (v8_current_cpu == "x87") {
     sources += [
       ### gcmole(arch:x87) ###
       "src/builtins/x87/builtins-x87.cc",
     ]
   }
 
   configs = [ ":internal_config" ]
 }
 
-v8_source_set("v8_builtins_setup") {
-  visibility = [ ":*" ]  # Only targets in this file can depend on this.
-
-  deps = [
-    ":v8_builtins_generators",
-  ]
-
-  sources = [
-    ### gcmole(all) ###
-    "src/setup-isolate-full.cc",
-  ]
-
-  configs = [ ":internal_config" ]
-}
-
 # This is split out to be a non-code containing target that the Chromium browser
 # DLL can depend upon to get only a version string.
 v8_header_set("v8_version") {
   configs = [ ":internal_config" ]
 
   sources = [
     "include/v8-version-string.h",
     "include/v8-version.h",
   ]
 }
@@ skipping 823 matching lines @@
     "src/runtime/runtime-strings.cc",
     "src/runtime/runtime-symbol.cc",
     "src/runtime/runtime-test.cc",
     "src/runtime/runtime-typedarray.cc",
     "src/runtime/runtime-utils.h",
     "src/runtime/runtime-wasm.cc",
     "src/runtime/runtime.cc",
     "src/runtime/runtime.h",
     "src/safepoint-table.cc",
     "src/safepoint-table.h",
-    "src/setup-isolate.h",
     "src/signature.h",
     "src/simulator.h",
     "src/small-pointer-list.h",
     "src/snapshot/code-serializer.cc",
     "src/snapshot/code-serializer.h",
     "src/snapshot/deserializer.cc",
     "src/snapshot/deserializer.h",
     "src/snapshot/natives-common.cc",
     "src/snapshot/natives.h",
     "src/snapshot/partial-serializer.cc",
@@ skipping 736 matching lines @@
     visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
     sources = [
       "src/snapshot/mksnapshot.cc",
     ]
 
     configs = [ ":internal_config" ]
 
     deps = [
       ":v8_base",
-      ":v8_builtins_setup",
       ":v8_libbase",
       ":v8_libplatform",
       ":v8_nosnapshot",
       "//build/config/sanitizers:deps",
       "//build/win:default_exe_manifest",
     ]
   }
 }
 
 v8_executable("mkpeephole") {
@@ skipping 604 matching lines @@
   ]
 
   configs = [
     ":external_config",
     ":internal_config_base",
   ]
 }
 
 v8_fuzzer("wasm_compile_fuzzer") {
 }