ash/common/system/tray/tray_utils.h - Issue 2803893002: Reuse the code within UpdateCheckMark()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/common/system/tray/tray_utils.h

Issue 2803893002: Reuse the code within UpdateCheckMark() (Closed)

Patch Set: Rename CheckMark -> SetCheckMarkVisible, UncheckMark -> SetCheckMarkInvisible. Update the comment. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ash/common/system/chromeos/palette/common_palette_tool.cc ('K') | « ash/common/system/chromeos/palette/common_palette_tool.cc ('k') | ash/common/system/tray/tray_utils.cc » ('j') | ash/common/system/tray/tray_utils.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ASH_COMMON_SYSTEM_TRAY_TRAY_UTILS_H_	5 #ifndef ASH_COMMON_SYSTEM_TRAY_TRAY_UTILS_H_
	tdanderson 2017/04/06 17:52:09 Ah, I didn't realize this file only had one thing Ah, I didn't realize this file only had one thing in it. We should probably just remove it and place SetupLabelForTray in tray_popup_utils.h instead (I can do that in a separate CL). In the meantime can you please put any new functions in tray_popup_utils.h instead?
6 #define ASH_COMMON_SYSTEM_TRAY_TRAY_UTILS_H_	6 #define ASH_COMMON_SYSTEM_TRAY_TRAY_UTILS_H_

7	7

8 namespace views {	8 namespace views {

9 class Label;	9 class Label;

10 }	10 }

11	11

12 namespace ash {	12 namespace ash {

	13 class HoverHighlightView;

13	14

14 // Sets up a Label properly for the tray (sets color, font etc.).	15 // Sets up a Label properly for the tray (sets color, font etc.).

15 void SetupLabelForTray(views::Label* label);	16 void SetupLabelForTray(views::Label* label);

16	17

	18 // Update the check mark when check or uncheck an item in system menu.

	19 void SetCheckMarkVisible(HoverHighlightView* container);

	20 void SetCheckMarkInvisible(HoverHighlightView* container);

17 } // namespace ash	21 } // namespace ash

18	22

19 #endif // ASH_COMMON_SYSTEM_TRAY_TRAY_UTILS_H_	23 #endif // ASH_COMMON_SYSTEM_TRAY_TRAY_UTILS_H_

OLD	NEW