Reuse the code within UpdateCheckMark()

ash/common/system/chromeos/audio/audio_detailed_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/chromeos/audio/audio_detailed_view.h"
 
 #include "ash/common/system/tray/hover_highlight_view.h"
 #include "ash/common/system/tray/tray_popup_utils.h"
+#include "ash/common/system/tray/tray_utils.h"
 #include "ash/common/system/tray/tri_view.h"
 #include "ash/resources/vector_icons/vector_icons.h"
 #include "ash/strings/grit/ash_strings.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chromeos/audio/cras_audio_handler.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/color_palette.h"
 #include "ui/gfx/paint_vector_icon.h"
 #include "ui/native_theme/native_theme.h"
 #include "ui/views/controls/image_view.h"
@@ skipping 84 matching lines @@
   scroll_content()->AddChildView(header);
 }
 
 HoverHighlightView* AudioDetailedView::AddScrollListItem(
     const base::string16& text,
     bool highlight,
     bool checked) {
   HoverHighlightView* container = new HoverHighlightView(this);
 
   container->AddLabelRow(text);
   if (checked) {

[tdanderson, 2017/04/06 17:52:09]

nit: In general in the code base we avoid braces for conditionals with a single
line body (https://google.github.io/styleguide/cppguide.html#Conditionals). So
here (and elsewhere in this CL) you should format as:

if (checked)
  SetCheckMarkVisible(container);


We usually only include braces if the body is multiline:

if (condition) {
  x++;
  y--;
}

or if the condition itself is multiline:

if (some_long_condition_over_80_chars &&
    something_else) {
  foo();
}

or if it is part of an if / else if / else if where at least one of those parts
is multiline:

if (condition) {
  x++;
} else if (condition2) {
  y++;
  z--;
} else {
  x += y;
}

-    gfx::ImageSkia check_mark =
-        gfx::CreateVectorIcon(kCheckCircleIcon, gfx::kGoogleGreen700);
-    container->AddRightIcon(check_mark, check_mark.width());
-    container->SetRightViewVisible(true);
-    container->SetAccessiblityState(
-        HoverHighlightView::AccessibilityState::CHECKED_CHECKBOX);
+    SetCheckMarkVisible(container);
   } else {
-    container->SetAccessiblityState(
-        HoverHighlightView::AccessibilityState::UNCHECKED_CHECKBOX);
+    SetCheckMarkInvisible(container);
   }
 
   scroll_content()->AddChildView(container);
   return container;
 }
 
 void AudioDetailedView::CreateItems() {
   CreateScrollableList();
   CreateTitleRow(IDS_ASH_STATUS_TRAY_AUDIO);
 }
@@ skipping 86 matching lines @@
       audio_handler->HasDualInternalMic()) {
     audio_handler->SwitchToFrontOrRearMic();
   } else {
     audio_handler->SwitchToDevice(device, true,
                                   CrasAudioHandler::ACTIVATE_BY_USER);
   }
 }
 
 }  // namespace tray
 }  // namespace ash