Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2803853004: Reland: VM [KERNEL] Avoid emitting :expr_temp and capturing :iterator (Closed)

Created:
3 years, 8 months ago by Dmitry Olshansky
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland: VM [KERNEL] Avoid emitting :expr_temp and capturing :iterator This allows us to bypass allocation of Context for some sync* function such as in Iteration.tree.syncstar benchmark. R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/19a352e0f597181283831d58f346c81f54fc2fa6

Patch Set 1 #

Patch Set 2 : VM [KERNEL] Avoid emitting :expr_temp and capturing :iterator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M runtime/observatory/tests/service/service.status View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/kernel_to_il.h View 1 3 chunks +6 lines, -1 line 0 comments Download
M runtime/vm/kernel_to_il.cc View 4 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Dmitry Olshansky
3 years, 8 months ago (2017-04-06 14:33:12 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 8 months ago (2017-04-06 14:50:07 UTC) #3
Dmitry Olshansky
3 years, 8 months ago (2017-04-06 15:18:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
19a352e0f597181283831d58f346c81f54fc2fa6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698