Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2803833003: Small steps towards deferred loading. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, dart-fe-team+reviews_google.com, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Tweak status file. Some of the compile-time errors result in passing tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -105 lines) Patch
M pkg/front_end/lib/src/fasta/builder/prefix_builder.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/import.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 4 chunks +19 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/service_kernel.status View 2 chunks +4 lines, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 5 chunks +5 lines, -11 lines 0 comments Download
M tests/isolate/isolate.status View 1 2 chunks +7 lines, -4 lines 0 comments Download
M tests/language/language_kernel.status View 1 7 chunks +55 lines, -69 lines 0 comments Download
M tests/lib/lib.status View 5 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
I don't plan to do much more just now to support deferred loading, and I ...
3 years, 8 months ago (2017-04-06 13:09:37 UTC) #2
karlklose
LGTM
3 years, 8 months ago (2017-04-06 13:17:02 UTC) #3
ahe
3 years, 8 months ago (2017-04-07 10:23:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1e70fef1a253f11aff79828c24dae7cc366fb8d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698