Fixing invalid window opacity/visibility combination with the shelf

ui/aura/window.cc

Index: ui/aura/window.cc
diff --git a/ui/aura/window.cc b/ui/aura/window.cc
index fe1ba06a4fa241b0e44b8f1c5676f48d62025790..b270f36544e4515ea805ce7181b7ff63ae4f9d02 100644
--- a/ui/aura/window.cc
+++ b/ui/aura/window.cc
@@ -338,8 +338,7 @@ void Window::Show() {
     // It is not allowed that a window is visible but the layers alpha is fully
     // transparent since the window would still be considered to be active but
     // could not be seen.
-    // TODO(skuhne): uncomment and fix issue 351553.
-    // DCHECK(!(visible_ && layer()->GetTargetOpacity() == 0.0f));
+    DCHECK(!(visible_ && layer()->GetTargetOpacity() == 0.0f));

[sky, 2014/05/13 21:43:07]

I think you should land this separately. That way if you have to revert you're
only reverting this part of the change.

[Mr4D (OOO till 08-26), 2014/05/13 22:08:17]

Indeed! Thanks, good idea! Done.

   }
   SetVisible(true);
 }