Fixing invalid window opacity/visibility combination with the shelf

ash/root_window_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/root_window_controller.h"
 
 #include "ash/session/session_state_delegate.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
@@ skipping 565 matching lines @@
   delete window1;
 
   ASSERT_FALSE(observer2.destroyed());
   delete window2;
 }
 
 typedef test::NoSessionAshTestBase NoSessionRootWindowControllerTest;
 
 // Make sure that an event handler exists for entire display area.
 TEST_F(NoSessionRootWindowControllerTest, Event) {
+  // Hide the shelf since it might otherwise get an event target.
+  RootWindowController* controller = Shell::GetPrimaryRootWindowController();
+  ShelfLayoutManager* shelf_layout_manager =
+      controller->GetShelfLayoutManager();
+  shelf_layout_manager->SetAutoHideBehavior(
+      ash::SHELF_AUTO_HIDE_ALWAYS_HIDDEN);
+
   aura::Window* root = Shell::GetPrimaryRootWindow();
   const gfx::Size size = root->bounds().size();
   aura::Window* event_target = root->GetEventHandlerForPoint(gfx::Point(0, 0));
   EXPECT_TRUE(event_target);
   EXPECT_EQ(event_target,
             root->GetEventHandlerForPoint(gfx::Point(0, size.height() - 1)));
   EXPECT_EQ(event_target,
             root->GetEventHandlerForPoint(gfx::Point(size.width() - 1, 0)));
   EXPECT_EQ(event_target,
             root->GetEventHandlerForPoint(gfx::Point(0, size.height() - 1)));
@@ skipping 165 matching lines @@
   modal_widget->Close();
 
   // Verify that mouse events are now unblocked to the root window.
   root_window_event_generator.ClickLeftButton();
   EXPECT_EQ(2, handler.num_mouse_events() / 2);
   root_window->RemovePreTargetHandler(&handler);
 }
 
 }  // namespace test
 }  // namespace ash