Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 280383008: Delete benchmarking extension, remove API's ability to enable/disable SPDY (Closed)

Created:
6 years, 7 months ago by mmenke
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Delete benchmarking extension, remove API's ability to enable/disable SPDY. Delete the "Example" benchmarking extension, as no one's using it, and we have better tools, like WebPageReplay. This keeps the benchmarking API, is it's used by telemetry and WebPageReplay, but does remove the function to enable/disable SPDY support at runtime. This is one step towards getting rid of the SPDY configuration globals. There are no tests for enabling/disabling SPDY when a URLRequestContext has in-flight requests, and supporting it really doesn't get us anything. BUG=372533 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270811

Patch Set 1 #

Patch Set 2 : Remove IPC message #

Patch Set 3 : Remove benchmarking extension instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4793 lines) Patch
M chrome/browser/chrome_net_benchmarking_message_filter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_net_benchmarking_message_filter.cc View 3 chunks +0 lines, -20 lines 0 comments Download
M chrome/common/benchmarking_messages.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/common/extensions/docs/examples/extensions/benchmark/README.txt View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/common/extensions/docs/examples/extensions/benchmark/background.html View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/benchmark/background.js View 1 2 1 chunk +0 lines, -492 lines 0 comments Download
D chrome/common/extensions/docs/examples/extensions/benchmark/jquery/jquery-1.8.2.min.js View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/common/extensions/docs/examples/extensions/benchmark/jquery/jquery.flot.dashes.js View 1 2 1 chunk +0 lines, -237 lines 0 comments Download
D chrome/common/extensions/docs/examples/extensions/benchmark/jquery/jquery.flot.min.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/examples/extensions/benchmark/jst/jsevalcontext.js View 1 2 1 chunk +0 lines, -409 lines 0 comments Download
D chrome/common/extensions/docs/examples/extensions/benchmark/jst/jstemplate.js View 1 2 1 chunk +0 lines, -1018 lines 0 comments Download
D chrome/common/extensions/docs/examples/extensions/benchmark/jst/jstemplate_test.js View 1 2 1 chunk +0 lines, -357 lines 0 comments Download
D chrome/common/extensions/docs/examples/extensions/benchmark/jst/util.js View 1 2 1 chunk +0 lines, -471 lines 0 comments Download
D chrome/common/extensions/docs/examples/extensions/benchmark/manifest.json View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/benchmark/options.html View 1 2 1 chunk +0 lines, -298 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/benchmark/options.js View 1 2 1 chunk +0 lines, -751 lines 0 comments Download
D chrome/common/extensions/docs/examples/extensions/benchmark/script.js View 1 2 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/common/extensions/docs/examples/extensions/benchmark/stopwatch.jpg View 1 2 Binary file 0 comments Download
D chrome/common/extensions/docs/examples/extensions/benchmark/util/sorttable.js View 1 2 1 chunk +0 lines, -487 lines 0 comments Download
D chrome/common/extensions/docs/examples/extensions/benchmark/util/table2CSV.js View 1 2 1 chunk +0 lines, -90 lines 0 comments Download
M chrome/renderer/net_benchmarking_extension.cc View 3 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
mmenke
Chris suggested I just remove the benchmarking extension. APIs are still currently used by telemetry ...
6 years, 7 months ago (2014-05-15 15:42:48 UTC) #1
Ryan Hamilton
LGTM, although there are a couple of files in the extension that appear to now ...
6 years, 7 months ago (2014-05-15 17:12:01 UTC) #2
mmenke
On 2014/05/15 17:12:01, Ryan Hamilton wrote: > LGTM, although there are a couple of files ...
6 years, 7 months ago (2014-05-15 17:15:51 UTC) #3
Ryan Hamilton
SGTM
6 years, 7 months ago (2014-05-15 17:16:33 UTC) #4
mmenke
Kalman: Please review chrome/common/extensions/docs/examples/extensions/benchmark/ (Note that the entire directory is just being deleted). I don't ...
6 years, 7 months ago (2014-05-15 18:03:22 UTC) #5
mmenke
Oh, and sky: In your portion of the code, I'm just removing a function in ...
6 years, 7 months ago (2014-05-15 18:04:09 UTC) #6
Tom Sepez
Rubberstamp LGTM on deleting message. Thanks.
6 years, 7 months ago (2014-05-15 18:34:36 UTC) #7
not at google - send to devlin
lgtm
6 years, 7 months ago (2014-05-15 19:21:46 UTC) #8
sky
LGTM
6 years, 7 months ago (2014-05-15 19:29:02 UTC) #9
mmenke
On 2014/05/15 19:29:02, sky wrote: > LGTM Thanks everyone!
6 years, 7 months ago (2014-05-15 19:40:14 UTC) #10
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 7 months ago (2014-05-15 19:40:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/280383008/60001
6 years, 7 months ago (2014-05-15 19:40:54 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 20:47:22 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 20:54:53 UTC) #14
Message was sent while issue was closed.
Change committed as 270811

Powered by Google App Engine
This is Rietveld 408576698