Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 280383007: Creating canvas dynamically in webrtc video quality tests (Closed)

Created:
6 years, 7 months ago by amogh.bihani
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Creating canvas dynamically in webrtc video quality tests The canvas on which the frame is captured is created dynamically. References of canvas and the remote video are passed instead of the hard coded 'Id's. TEST=out/Release/browser_tests --gtest_filter=WebRtcVideoQualityBrowserTest* --run-manual --ui-test-action-max-timeout=150000 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270726

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -54 lines) Patch
M chrome/test/data/webrtc/video_extraction.js View 5 chunks +18 lines, -40 lines 0 comments Download
M chrome/test/data/webrtc/webrtc_video_quality_test.html View 1 1 chunk +4 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
amogh.bihani
PTAL. I have made the changes as suggested in the previous CL. https://codereview.chromium.org/254803002/ This CL ...
6 years, 7 months ago (2014-05-13 13:23:24 UTC) #1
amogh.bihani
Ping!
6 years, 7 months ago (2014-05-15 09:19:53 UTC) #2
phoglund_chromium
lgtm (sorry for the delay)
6 years, 7 months ago (2014-05-15 09:34:13 UTC) #3
amogh.bihani
On 2014/05/15 09:34:13, phoglund wrote: > lgtm (sorry for the delay) Thanks :)
6 years, 7 months ago (2014-05-15 09:48:08 UTC) #4
amogh.bihani
The CQ bit was checked by amogh.bihani@samsung.com
6 years, 7 months ago (2014-05-15 09:48:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amogh.bihani@samsung.com/280383007/20001
6 years, 7 months ago (2014-05-15 09:50:19 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 17:42:01 UTC) #7
Message was sent while issue was closed.
Change committed as 270726

Powered by Google App Engine
This is Rietveld 408576698