Fix Chrome OS virtual keyboard accessibility

ui/views/accessibility/ax_widget_obj_wrapper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/accessibility/ax_widget_obj_wrapper.h"
 
 #include "base/strings/utf_string_conversions.h"
+#include "ui/accessibility/ax_action_data.h"
 #include "ui/accessibility/ax_node_data.h"
 #include "ui/views/accessibility/ax_aura_obj_cache.h"
 #include "ui/views/accessibility/ax_aura_obj_wrapper.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_delegate.h"
 
 namespace views {
 
 AXWidgetObjWrapper::AXWidgetObjWrapper(Widget* widget) : widget_(widget) {
   widget->AddObserver(this);
@@ skipping 31 matching lines @@
       base::UTF16ToUTF8(
           widget_->widget_delegate()->GetAccessibleWindowTitle()));
   out_node_data->location = gfx::RectF(widget_->GetWindowBoundsInScreen());
   out_node_data->state = 0;
 }
 
 int32_t AXWidgetObjWrapper::GetID() {
   return AXAuraObjCache::GetInstance()->GetID(widget_);
 }
 
+bool AXWidgetObjWrapper::HandleAccessibleAction(

[David Tseng, 2017/04/06 16:45:44]

I think this is the wrong level of abstraction to handle this.

An AXHostDelegate handles actions on behalf of a tree source. So, ideally, this
would belong in the AXHostDelegates for web (RenderFrameHost), desktop
(AutomationMangerAura), arc (ArcAccessibilityHelperBridge)

[dmazzoni, 2017/04/07 23:34:09]

No, because a HIT_TEST is fired on the root. We just have coordinates,
we don't know whether to delegate it to a window, a widget, or
a particular frame yet.

Yes, the AXHostDelegate should handle the HIT_TEST action, but it
should forward it to its root node to handle from there.

+    const ui::AXActionData& action) {
+  if (action.action == ui::AX_ACTION_HIT_TEST) {
+    // For a hit test event, try to delegate to a View, and if that
+    // fails fire the event directly.
+    views::View* root_view = widget_->GetRootView();
+    views::View* hit_view =
+        root_view->GetEventHandlerForPoint(action.target_point);
+    if (hit_view) {
+      AXAuraObjWrapper* view_wrapper =
+          AXAuraObjCache::GetInstance()->GetOrCreate(hit_view);
+      if (view_wrapper)
+        return view_wrapper->HandleAccessibleAction(action);
+    }
+
+    AXAuraObjCache::GetInstance()->FireEvent(this,
+                                             action.hit_test_event_to_fire);
+    return true;
+  }
+
+  return false;
+}
+
 void AXWidgetObjWrapper::OnWidgetDestroying(Widget* widget) {
   AXAuraObjCache::GetInstance()->Remove(widget);
 }
 
 void AXWidgetObjWrapper::OnWidgetClosing(Widget* widget) {
   AXAuraObjCache::GetInstance()->Remove(widget);
 }
 
 void AXWidgetObjWrapper::OnWidgetVisibilityChanged(Widget*, bool) {
   // If a widget changes visibility it may affect what's focused, in particular
   // when a widget that contains the focused view gets hidden.
   AXAuraObjCache::GetInstance()->OnFocusedViewChanged();
 }
 
 void AXWidgetObjWrapper::OnWillRemoveView(Widget* widget, View* view) {
   AXAuraObjCache::GetInstance()->RemoveViewSubtree(view);
 }
 
 }  // namespace views