components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc - Issue 2803813003: Adding a data saver page id to requests and reports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc

Issue 2803813003: Adding a data saver page id to requests and reports (Closed)

Patch Set: bengr nits Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc

index 7b0d644f0b5af717230fd1c8d946bd7ef0cbc6f5..76f0dddd3d45d5f40afbf47b1778ef59377ae6bb 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc

@@ -92,6 +92,10 @@ void AddDataToPageloadMetrics(const DataReductionProxyData& request_data,

request_data.effective_connection_type()));

request->set_compressed_page_size_bytes(timing.network_bytes);

request->set_original_page_size_bytes(timing.original_network_bytes);

+ if (request_data.page_id()) {

+ request->set_page_id(request_data.page_id().value());

+ }

}

// Adds |current_time| as the metrics sent time to |request_data|, and returns