third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp - Issue 2803733002: Convert ASSERT(foo) to DCHECK(foo) in platform/audio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp

Issue 2803733002: Convert ASSERT(foo) to DCHECK(foo) in platform/audio (Closed)

Patch Set: Mechanical change from ASSERT(foo) to DCHECK(foo) Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp

diff --git a/third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp b/third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp

index 06d896c9ecf29d2d7d78cc0899f6614d46a8f449..6534e09f744caed5649e6809afac03ed68760748 100644

--- a/third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp

+++ b/third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp

@@ -174,14 +174,14 @@ void ReverbConvolver::process(const AudioChannel* sourceChannel,

bool isSafe = sourceChannel && destinationChannel &&

sourceChannel->length() >= framesToProcess &&

destinationChannel->length() >= framesToProcess;

- ASSERT(isSafe);

+ DCHECK(isSafe);

if (!isSafe)

return;

const float* source = sourceChannel->data();

float* destination = destinationChannel->mutableData();

bool isDataSafe = source && destination;

- ASSERT(isDataSafe);

+ DCHECK(isDataSafe);

if (!isDataSafe)

return;