third_party/WebKit/Source/platform/audio/ReverbAccumulationBuffer.cpp - Issue 2803733002: Convert ASSERT(foo) to DCHECK(foo) in platform/audio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/audio/ReverbAccumulationBuffer.cpp

Issue 2803733002: Convert ASSERT(foo) to DCHECK(foo) in platform/audio (Closed)

Patch Set: Mechanical change from ASSERT(foo) to DCHECK(foo) Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/audio/Reverb.cpp ('k') | third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/audio/ReverbAccumulationBuffer.cpp

diff --git a/third_party/WebKit/Source/platform/audio/ReverbAccumulationBuffer.cpp b/third_party/WebKit/Source/platform/audio/ReverbAccumulationBuffer.cpp

index 7c4ff6ee2043ae701b3e43d65b5907c7e9a7e68b..c83fc532a8d6580840692550d0fa42b8a725741a 100644

--- a/third_party/WebKit/Source/platform/audio/ReverbAccumulationBuffer.cpp

+++ b/third_party/WebKit/Source/platform/audio/ReverbAccumulationBuffer.cpp

@@ -42,7 +42,7 @@ void ReverbAccumulationBuffer::readAndClear(float* destination,

bool isCopySafe =

m_readIndex <= bufferLength && numberOfFrames <= bufferLength;

- ASSERT(isCopySafe);

+ DCHECK(isCopySafe);

if (!isCopySafe)

return;

@@ -91,7 +91,7 @@ int ReverbAccumulationBuffer::accumulate(float* source,

bool isSafe = writeIndex <= bufferLength &&

numberOfFrames1 + writeIndex <= bufferLength &&

numberOfFrames2 <= bufferLength;

- ASSERT(isSafe);

+ DCHECK(isSafe);

if (!isSafe)

return 0;