fix #29233, final fields can be settable in a mock

fix #29233, final fields can be settable in a mock
also fix #29273, user mixins can override native methods

R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/8ada796a8695ecff0997e2bcf89ee717457b41bc

[Jennifer Messerly, 2017-04-07 19:16:11]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[vsm, 2017-04-07 20:32:03]

lgtm!

https://codereview.chromium.org/2803673007/diff/10001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2803673007/diff/10001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:1800: // add forwarders.
Probably could kill this comment given the method comment.  :-)

https://codereview.chromium.org/2803673007/diff/10001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:1802: // Mixin members
don't live direction on the class, they live on the
direction -> directly

Does extensions == null imply this is a mixin?

https://codereview.chromium.org/2803673007/diff/10001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/compiler/property_model.dart (right):

https://codereview.chromium.org/2803673007/diff/10001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/property_model.dart:267: // members are
allowed to "override" concrete ones in Dart.
Unrelated to this CL since the code just moved, but does this cause a problem if
the abstract override has a looser signature?

[Jennifer Messerly, 2017-04-07 20:50:22]

Thanks Vijay!!!

https://codereview.chromium.org/2803673007/diff/10001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2803673007/diff/10001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:1800: // add forwarders.
On 2017/04/07 20:32:02, vsm wrote:
> Probably could kill this comment given the method comment.  :-)

Done.

https://codereview.chromium.org/2803673007/diff/10001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:1802: // Mixin members
don't live direction on the class, they live on the
On 2017/04/07 20:32:02, vsm wrote:
> direction -> directly
> 
> Does extensions == null imply this is a mixin?

I was afraid this would be a bit non-obvious. Let me know if the refactored
version is more clear.

https://codereview.chromium.org/2803673007/diff/10001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/compiler/property_model.dart (right):

https://codereview.chromium.org/2803673007/diff/10001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/property_model.dart:267: // members are
allowed to "override" concrete ones in Dart.
On 2017/04/07 20:32:02, vsm wrote:
> Unrelated to this CL since the code just moved, but does this cause a problem
if
> the abstract override has a looser signature?  

Hmmm quite possibly! I'll see if I can reproduce that and if so, file a bug
about it. Good eye -- you may have found a soundness bug! :)

[vsm, 2017-04-07 20:57:35]

lgtm!

https://codereview.chromium.org/2803673007/diff/20001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2803673007/diff/20001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:1799: void
emitExtenstions(
nit: emitExtenstions -> emitExtensions

[Jennifer Messerly, 2017-04-07 21:13:00]

Description was changed from

==========
fix #29233, final fields can be settable in a mock
also fix #29273, user mixins can override native methods
==========

to

==========
fix #29233, final fields can be settable in a mock
also fix #29273, user mixins can override native methods

R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8ada796a8695ecff0997e2bcf89ee717457b41bc
==========

[Jennifer Messerly, 2017-04-07 21:13:01]

Committed patchset #3 (id:20001) manually as
8ada796a8695ecff0997e2bcf89ee717457b41bc (presubmit successful).