Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2803673006: PlzNavigate: ensure we don't create extra-processes for ServiceWorkers (Closed)

Created:
3 years, 8 months ago by clamy
Modified:
3 years, 7 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, creis+watch_chromium.org, shimazu+serviceworker_chromium.org, nasko+codewatch_chromium.org, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, ajwong+watch_chromium.org, horo+watch_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: ensure we don't create extra-processes for ServiceWorkers This CL adds a function to SiteInstanceImpl that finds a SiteInstance that can be used to display a site based on a BrowserContext and uses in ServiceWorkerProcessManager when no RenderProcessHost is already in use for a particular pattern. In order for this function to work, the SiteInstance now records which site it was used to display. We also keep track of BrowsingInstances to be able to iterate over all BrowsingInstances in order to find a SiteInstance. BUG=705318 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -4 lines) Patch
M content/browser/browsing_instance.h View 4 chunks +16 lines, -0 lines 0 comments Download
M content/browser/browsing_instance.cc View 2 chunks +57 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_process_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/site_instance_impl.h View 3 chunks +7 lines, -0 lines 0 comments Download
M content/browser/site_instance_impl.cc View 3 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (8 generated)
Charlie Reis
3 years, 7 months ago (2017-05-03 23:28:49 UTC) #7
Just a note: I think we're probably abandoning this in favor of the approach on
https://codereview.chromium.org/2861433002/.

Powered by Google App Engine
This is Rietveld 408576698