Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2803633004: Revert of Keep track in the browser of which frames have onunload and onbeforeunload handlers. (Closed)

Created:
3 years, 8 months ago by achuithb
Modified:
3 years, 8 months ago
Reviewers:
jam, nasko, dcheng
CC:
chromium-reviews, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Keep track in the browser of which frames have onunload and onbeforeunload handlers. (patchset #10 id:180001 of https://codereview.chromium.org/2783723002/ ) Reason for revert: Creating a revert patchset for testing. Will not be submitted. Original issue's description: > Keep track in the browser of which frames have onunload and onbeforeunload handlers. > > This allows PlzNavigate to only pause fetching the request if it knows that the page has an onbeforeunload handler, where today it currently always goes to the renderer. This avoids delaying the network requests in the 95% cases that don't onbeforeunload handler on a process hop to the renderer. > > BUG=365039, 705559 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > R=dcheng@chromium.org, nasko@chromium.org > > Review-Url: https://codereview.chromium.org/2783723002 . > Cr-Commit-Position: refs/heads/master@{#460581} > Committed: https://chromium.googlesource.com/chromium/src/+/a2c84a7664eceb5cbeaae5bf1ec32da0060e3097 TBR=nasko@chromium.org,dcheng@chromium.org,jam@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=365039, 705559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -137 lines) Patch
M chrome/browser/lifetime/browser_close_manager.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/browser_side_navigation_browsertest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_request.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 3 chunks +11 lines, -15 lines 0 comments Download
M content/browser/frame_host/navigator_impl_unittest.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 3 chunks +0 lines, -10 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 4 chunks +1 line, -33 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 10 chunks +44 lines, -4 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M content/test/test_render_frame_host.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 3 chunks +19 lines, -3 lines 0 comments Download
M ui/views/controls/webview/web_dialog_view.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
achuithb
3 years, 8 months ago (2017-04-05 17:40:44 UTC) #1
Created Revert of Keep track in the browser of which frames have onunload and
onbeforeunload handlers.

Powered by Google App Engine
This is Rietveld 408576698