Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2803613005: Add retry to test scripts' attempt to delete temporary Chrome config dirs. (Closed)

Created:
3 years, 8 months ago by Bill Hesse
Modified:
3 years, 8 months ago
Reviewers:
sortie
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add retry to test scripts' attempt to delete temporary Chrome config dirs. BUG=https://github.com/dart-lang/sdk/issues/29282 R=sortie@google.com Committed: https://github.com/dart-lang/sdk/commit/87f38760e6017c29df5a974edb6ade9652bf8e7a

Patch Set 1 #

Patch Set 2 : Change timeout to 40s, apply dartfmt to changed file. #

Patch Set 3 : Changed wording of messages. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -19 lines) Patch
M tools/testing/dart/browser_controller.dart View 1 2 9 chunks +39 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
3 years, 8 months ago (2017-04-06 13:05:49 UTC) #2
sortie
lgtm Bikeshed of the error messages: Maybe put the error word at the start "error: ...
3 years, 8 months ago (2017-04-06 13:34:02 UTC) #3
Bill Hesse
3 years, 8 months ago (2017-04-06 14:06:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
87f38760e6017c29df5a974edb6ade9652bf8e7a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698