Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h

Issue 2803593005: Avoid unnecessary byte-swapping in blink's SerializedScriptValue. (Closed)
Patch Set: Correct handling for SSV version 0. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h
index 08d5b8d24396af804fc5b9d69b946a79ebec50e9..5292e694ed4da06632868c8fa5925f0c68aed68b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h
+++ b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h
@@ -75,7 +75,12 @@ class CORE_EXPORT SerializedScriptValue
// Version 9: Added Map and Set support.
// [versions skipped]
// Version 16: Separate versioning between V8 and Blink.
- static const uint32_t wireFormatVersion = 16;
+ // Version 17: Remove unnecessary byte flipping in wire format.
+ //
+ // The following versions cannot be used, in order to be able to
+ // deserialize version 0 SSVs. The class implementation has details.
+ // DO NOT USE: 35, 64, 68, 73, 78, 82, 83, 85, 91, 98, 102, 108, 123.
jsbell 2017/04/07 23:40:34 static_assert() please!
pwnall 2017/04/08 01:09:08 Done. Thanks for the suggestion! That's a great id
+ static const uint32_t wireFormatVersion = 17;
struct SerializeOptions {
STACK_ALLOCATED();

Powered by Google App Engine
This is Rietveld 408576698