Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2803593002: Add month and year to time_format. (Closed)

Created:
3 years, 8 months ago by Olivier
Modified:
3 years, 7 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, srahim+watch_chromium.org, jshin+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add month and year to time_format. Add the possibility to have month and years in time format. A year is defined as 365 days. A month is defined as 1year / 12. '1 month' means more than one month and less than two month (same for years). BUG=694451

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -91 lines) Patch
M ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/l10n/formatter.h View 3 chunks +8 lines, -2 lines 0 comments Download
M ui/base/l10n/formatter.cc View 6 chunks +39 lines, -27 lines 0 comments Download
M ui/base/l10n/time_format.h View 3 chunks +29 lines, -7 lines 1 comment Download
M ui/base/l10n/time_format.cc View 4 chunks +34 lines, -2 lines 0 comments Download
M ui/base/l10n/time_format_unittest.cc View 8 chunks +139 lines, -51 lines 0 comments Download
M ui/strings/ui_strings.grd View 3 chunks +30 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
Olivier
gambard for RL, jshin for time_format. Some choices (rounding, definitions of month) may be changed. ...
3 years, 8 months ago (2017-04-05 09:12:20 UTC) #2
gambard
reading list lgtm
3 years, 8 months ago (2017-04-05 09:17:14 UTC) #3
Olivier
Friendly ping
3 years, 8 months ago (2017-04-10 08:32:15 UTC) #4
jungshik at Google
On 2017/04/10 08:32:15, Olivier Robin wrote: > Friendly ping Sorry. I'm looking.
3 years, 8 months ago (2017-04-11 18:10:44 UTC) #5
jungshik at Google
LGTM with nits taken care of. https://codereview.chromium.org/2803593002/diff/1/ui/base/l10n/time_format.h File ui/base/l10n/time_format.h (right): https://codereview.chromium.org/2803593002/diff/1/ui/base/l10n/time_format.h#newcode77 ui/base/l10n/time_format.h:77: // twelfth of ...
3 years, 8 months ago (2017-04-11 19:01:32 UTC) #6
gambard
3 years, 7 months ago (2017-04-28 09:09:42 UTC) #7
Message was sent while issue was closed.
Closing this as https://codereview.chromium.org/2845693002/ landed

Powered by Google App Engine
This is Rietveld 408576698