Added synchronous socket implementation to dart:io.

runtime/bin/eventhandler_win.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_BIN_EVENTHANDLER_WIN_H_
 #define RUNTIME_BIN_EVENTHANDLER_WIN_H_
 
 #if !defined(RUNTIME_BIN_EVENTHANDLER_H_)
 #error Do not include eventhandler_win.h directly; use eventhandler.h instead.
 #endif
@@ skipping 428 matching lines @@
   // this queue and processed by dart isolates.
   int accepted_count_;
 
   DISALLOW_COPY_AND_ASSIGN(ListenSocket);
 };
 
 
 // Information on connected sockets.
 class ClientSocket : public DescriptorInfoSingleMixin<SocketHandle> {
  public:
-  explicit ClientSocket(intptr_t s)
+  explicit ClientSocket(intptr_t s, bool sync = false)

[zra, 2017/04/07 05:29:27]

The synchronous socket implementation should be completely separate from the
asynchronous implementation. So, let's not overload this class. Instead, make a
new wrapper around the HANDLE in sync_socket_win.cc/h.

[zra, 2017/04/07 14:41:12]

After thinking about this some more, I think we should cut the Windows
implementation from this CL since you don't have a windows box to develop on. We
can mark the implementation UNIMPLEMENTED() in sync_socket_win.cc and mark the
tests as Crash in the status file.

[bkonyi, 2017/04/10 19:20:04]

Sounds good. Removed.

       : DescriptorInfoSingleMixin(s, true),
         DisconnectEx_(NULL),
         next_(NULL),
         connected_(false),
-        closed_(false) {
+        closed_(false),
+        sync_(sync),
+  {
     LoadDisconnectEx();
     type_ = kClientSocket;
   }
 
   virtual ~ClientSocket() {
     // Don't delete this object until all pending requests have been handled.
     ASSERT(!HasPendingRead());
     ASSERT(!HasPendingWrite());
     ASSERT(next_ == NULL);
     ASSERT(closed_ == true);
@@ skipping 25 matching lines @@
   static intptr_t disconnecting() { return disconnecting_; }
 #endif
 
  private:
   bool LoadDisconnectEx();
 
   LPFN_DISCONNECTEX DisconnectEx_;
   ClientSocket* next_;
   bool connected_;
   bool closed_;
+  bool sync_;
 
 #if defined(DEBUG)
   static intptr_t disconnecting_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(ClientSocket);
 };
 
 
 class DatagramSocket : public DescriptorInfoSingleMixin<SocketHandle> {
@@ skipping 65 matching lines @@
   bool shutdown_;
   HANDLE completion_port_;
 
   DISALLOW_COPY_AND_ASSIGN(EventHandlerImplementation);
 };
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // RUNTIME_BIN_EVENTHANDLER_WIN_H_