Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 280353002: Disable auto-reload on mobile canary and dev channels. (Closed)

Created:
6 years, 7 months ago by Elly Fong-Jones
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Visibility:
Public.

Description

Disable auto-reload on mobile canary and dev channels. We currently don't have any data on auto-reload's usefulness or, more importantly, its battery impact. Disabling it for dev pending investigation. TEST=unit,trybot BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270131

Patch Set 1 #

Total comments: 1

Patch Set 2 : Hard disable on mobile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Elly Fong-Jones
PTAL?
6 years, 7 months ago (2014-05-12 18:47:11 UTC) #1
Randy Smith (Not in Mondays)
https://codereview.chromium.org/280353002/diff/1/chrome/browser/chrome_content_browser_client.cc File chrome/browser/chrome_content_browser_client.cc (right): https://codereview.chromium.org/280353002/diff/1/chrome/browser/chrome_content_browser_client.cc#newcode1569 chrome/browser/chrome_content_browser_client.cc:1569: chrome::VersionInfo::CHANNEL_UNKNOWN; I'm concerned that using CHANNEL_UNKNOWN will mean that ...
6 years, 7 months ago (2014-05-12 18:51:32 UTC) #2
Elly Fong-Jones
PTAL?
6 years, 7 months ago (2014-05-12 20:24:46 UTC) #3
Randy Smith (Not in Mondays)
lgtm
6 years, 7 months ago (2014-05-12 20:55:01 UTC) #4
Elly Fong-Jones
The CQ bit was checked by ellyjones@chromium.org
6 years, 7 months ago (2014-05-13 15:03:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ellyjones@chromium.org/280353002/20001
6 years, 7 months ago (2014-05-13 15:03:43 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 16:57:01 UTC) #7
Message was sent while issue was closed.
Change committed as 270131

Powered by Google App Engine
This is Rietveld 408576698